Implementing a custom for user defined repositories #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation of the suggestion in domtronn#127. Now there is a custom where the user can specify for the presence of which files should be considered as a directory of a repository.
wyuenho
requested changes
Feb 11, 2019
| @@ -526,6 +543,12 @@ | |||
| ;; Functions Start | |||
| ;; ==================== | |||
|
|
|||
| (defun* all-the-icons-is-repo (path) | |||
There was a problem hiding this comment.
Suggested change
| (defun* all-the-icons-is-repo (path) | |
| (defun all-the-icons-is-repo (path) |
| @@ -526,6 +543,12 @@ | |||
| ;; Functions Start | |||
| ;; ==================== | |||
|
|
|||
| (defun* all-the-icons-is-repo (path) | |||
| "Check if PATH is a repository." | |||
| (dolist (repo all-the-icons-mode-repositories) | |||
There was a problem hiding this comment.
Emacs already has a vc-mode built-in that comes with a custom called vc-directory-exclusion-list, can you try reusing it in your all-the-icons-is-repo, how about this:
Suggested change
| (dolist (repo all-the-icons-mode-repositories) | |
| (dolist (repo vc-directory-exclusion-list) |
Don't forget to load this variable somewhere in your file as well.
|
@palikar are you still working on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the suggestion in #127. Now there is a custom where
the user can specify for the presence of which files should be considered
as a directory of a repository.