LONDON| DONARA BLANC | TV PROJECT SHOW | LEVEL 500 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-donarbl-tv ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| <option value="">Select a Show</option> | ||
| </select> | ||
| <div id="episode-controls" style="display: none;"> | ||
| <input type="text" id="episode-search" placeholder="Search episodes..." /> |
There was a problem hiding this comment.
These inputs do not have associated labels, so this front end does not score 100 on Lighthouse. Please do always associate form controls with labels so your interface can function correctly.
| <div class="container"> | ||
| <p>© 2024 TV Series Episodes. All rights reserved.</p> | ||
| <p>© 2025 TV Series Shows and Episodes. All rights reserved.</p> |
There was a problem hiding this comment.
I think this should be for TV Maze, the copyright.
| </article>`; | ||
| } | ||
|
|
||
| function renderShows(showsToDisplay) { | ||
| const showsGrid = document.getElementById('shows-grid'); |
There was a problem hiding this comment.
What are the risks of innerHTML? Why does the prep content not use this strategy?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.