Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to stop, warn or log when pull/checkout fails #44

Merged

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Dec 1, 2023

Closes #9

Changes:
The load_pkgs now checks for the status of the pull/checkout and log this for the user.
The user can choose if they need an error, warning, or message logged when git failure occurs. The default is warning.
This can also be set using an option in their .Rprofile using:

options('multiloadr.load.verbose' = 'error') # stop with an error
options('multiloadr.load.verbose' = 'warning') # show a warning => default
options('multiloadr.load.verbose' = 'message') # show a message

@vedhav
Copy link
Contributor Author

vedhav commented Dec 9, 2023

Hey @donyunardi
Looks like the CI failed because there was an error installing httpuv and shiny in the Install dependencies step. I triggered the check by creating a PR on the fork and it was successful. However, I think we can use ubuntu-latest ubuntu-20.04 (the release version of ubuntu does not seem to install R release version properly) instead of macos-latest for the CI along with R release instead of 4.2.2.

@vedhav
Copy link
Contributor Author

vedhav commented Dec 9, 2023

Hopefully, you like the CI changes I proposed I was able to implement them (after a few tries as always 😆). I checked the CI on the fork and it seems to work now, runs faster too 😉
Screenshot 2023-12-09 at 3 04 45 PM

Copy link
Owner

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for these improvements, @vedhav!
Just had small changes.
If you don't have time, I'd be more than happy to make the changes.

R/load_pkgs.R Outdated Show resolved Hide resolved
R/load_pkgs.R Outdated Show resolved Hide resolved
R/load_pkgs.R Outdated Show resolved Hide resolved
@donyunardi
Copy link
Owner

donyunardi commented Dec 9, 2023

Hopefully, you like the CI changes I proposed I

I do! Thank you!

Copy link
Owner

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@donyunardi donyunardi merged commit 6f0b990 into donyunardi:main Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

investigate load_pkgs(git_pull=TRUE)
2 participants