Fixed argument variable reference resolution in stashless functions

dop251 · Aug 17, 2021 · 07a7fd9 · 07a7fd9
1 parent acd0507
commit 07a7fd9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/compiler_test.go b/compiler_test.go
@@ -4113,6 +4113,17 @@ func TestArrowUseStrict(t *testing.T) {
 	}
 }
 
+func TestParameterOverride(t *testing.T) {
+	const SCRIPT = `
+	function f(arg) {
+		var arg = arg || "default"
+		return arg
+	}
+	f()
+	`
+	testScript1(SCRIPT, asciiString("default"), t)
+}
+
 /*
 func TestBabel(t *testing.T) {
 	src, err := ioutil.ReadFile("babel7.js")

diff --git a/vm.go b/vm.go
@@ -2326,7 +2326,7 @@ func (r *resolveMixedStack) exec(vm *vm) {
 	if r.idx > 0 {
 		idx = vm.sb + vm.args + r.idx
 	} else {
-		idx = vm.sb + r.idx
+		idx = vm.sb - r.idx
 	}
 
 	ref = newStashRef(r.typ, r.name, (*[]Value)(&vm.stack), idx)