Skip to content

Commit

Permalink
Fix using runtime.NewArrayBuffer
Browse files Browse the repository at this point in the history
After the templating changes calling `NewArrayBuffer` will make an
object but will set it's prototype to nil.

This change uses the new function call that will create the prototype if
not created yet.

It also changes in two other places where it seemed like it was missed.
  • Loading branch information
mstoykov committed Sep 19, 2023
1 parent 9410bca commit 07c7e94
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions builtin_typedarrays.go
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ func (r *Runtime) typedArrayProto_filter(call FunctionCall) Value {
}
}
c := r.speciesConstructorObj(o, ta.defaultCtor)
ab := r._newArrayBuffer(r.global.ArrayBufferPrototype, nil)
ab := r._newArrayBuffer(r.getArrayBufferPrototype(), nil)
ab.data = buf
kept := r.toConstructor(ta.defaultCtor)([]Value{ab.val}, ta.defaultCtor)
if c == ta.defaultCtor {
Expand Down Expand Up @@ -1215,7 +1215,7 @@ func (r *Runtime) typedArray_of(call FunctionCall) Value {
}

func (r *Runtime) allocateTypedArray(newTarget *Object, length int, taCtor typedArrayObjectCtor, proto *Object) *typedArrayObject {
buf := r._newArrayBuffer(r.global.ArrayBufferPrototype, nil)
buf := r._newArrayBuffer(r.getArrayBufferPrototype(), nil)
ta := taCtor(buf, 0, length, r.getPrototypeFromCtor(newTarget, nil, proto))
if length > 0 {
buf.data = allocByteSlice(length * ta.elemSize)
Expand Down
2 changes: 1 addition & 1 deletion typedarrays.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ func (a ArrayBuffer) Detached() bool {
// using this typed array will result in unaligned access which may cause performance degradation or runtime panics
// on some architectures or configurations.
func (r *Runtime) NewArrayBuffer(data []byte) ArrayBuffer {
buf := r._newArrayBuffer(r.global.ArrayBufferPrototype, nil)
buf := r._newArrayBuffer(r.getArrayBufferPrototype(), nil)
buf.data = data
return ArrayBuffer{
buf: buf,
Expand Down

0 comments on commit 07c7e94

Please sign in to comment.