Fixed String.prototype.split() when string is empty and limit is > 0. F…

…ixes #588.
dop251 · Jul 7, 2024 · b1681fb · b1681fb
1 parent eb1f15e
commit b1681fb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/builtin_string.go b/builtin_string.go
@@ -825,21 +825,16 @@ func (r *Runtime) stringproto_split(call FunctionCall) Value {
 
 	separator := separatorValue.String()
 
-	excess := false
 	str := s.String()
-	if limit > len(str) {
-		limit = len(str)
-	}
 	splitLimit := limit
 	if limit > 0 {
 		splitLimit = limit + 1
-		excess = true
 	}
 
 	// TODO handle invalid UTF-16
 	split := strings.SplitN(str, separator, splitLimit)
 
-	if excess && len(split) > limit {
+	if limit > 0 && len(split) > limit {
 		split = split[:limit]
 	}
 

diff --git a/builtin_string_test.go b/builtin_string_test.go
@@ -276,3 +276,13 @@ func TestValueStringBuilder(t *testing.T) {
 	})
 
 }
+
+func TestStringSplit(t *testing.T) {
+	const SCRIPT = `
+	assert(compareArray("".split("#",2), [""]));
+	assert(compareArray("".split("#"), [""]));
+	assert(compareArray("".split("",2), []));
+	assert(compareArray("".split(""), []));
+`
+	testScriptWithTestLib(SCRIPT, _undefined, t)
+}