Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Dmitry Panov <[email protected]>
  • Loading branch information
mstoykov and dop251 authored Oct 24, 2024
1 parent 85fc80e commit fba0ace
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions builtin_promise.go
Original file line number Diff line number Diff line change
Expand Up @@ -604,8 +604,8 @@ func (r *Runtime) wrapPromiseReaction(fObj *Object) func(interface{}) error {
}

// NewPromise creates and returns a Promise and resolving functions for it.
// The returned errors will be Interrupt errors that should be propagated upwards.
// Exceptions are handle through [PromiseRejectionTracker].
// The returned errors will be uncatchable errors, such as InterruptedError or StackOverflowError, which should be propagated upwards.
// Exceptions are handled through [PromiseRejectionTracker].
//
// WARNING: The returned values are not goroutine-safe and must not be called in parallel with VM running.
// In order to make use of this method you need an event loop such as the one in goja_nodejs (https://github.com/dop251/goja_nodejs)
Expand Down

0 comments on commit fba0ace

Please sign in to comment.