-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce datastructures from committime cleanup #1043
base: master
Are you sure you want to change the base?
Introduce datastructures from committime cleanup #1043
Conversation
Signed-off-by: Kevin M Granger <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
|
||
|
||
@attrs.frozen | ||
class GitRepo: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a replace of CommitMetric right?
If so, please checks the changes here #900 so they are also applied here
And if you want, you can look into this issue #903
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not a replacement, but is part of the replacement input.
Mind if I ask a few more questions in #900?
Signed-off-by: Kevin M Granger <[email protected]>
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
@KevinMGranger: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I'm splitting up #720 into pieces so it's easier to review. This is an unobtrusive change, just copying over datastructures from that PR. (And unit tests for one of them).
Side note:
make unit-tests
gives me a bunch ofModuleNotFoundError: No module named 'exporters'
errors. What gives?