Deserialization cleanup, test simplification, coverage expansion

[KevinMGranger]

related to #757

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[KevinMGranger]

The new mockoon tests did catch an issue here, but that made me see two things:

• it's hard to debug with the current way we run the mockoon container
• the deserialization framework still doesn't give enough context for certain errors.

I'll address both of those separately.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kevinmgranger. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr823-356e0c6 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

[KevinMGranger]

This is good enough as-is, and more tests can be added later.

[KevinMGranger]

@mateusoliveira43 I'm not familiar with the workflow for updating the chart patch versions. But isn't that only supposed to happen on a release anyway?

[mateusoliveira43]

@KevinMGranger we changed to apply the change to each PR, ref https://pelorus.readthedocs.io/en/latest/Development/#versioning-process (I think there was a discussion on this, but do not have the link)

on release, we bump rc versions to non rc

[KevinMGranger]

I'm trying to do that, but it can't find the operator-sdk binary.

I try to re-run make cli_dev_tools, but I get:

Found system python version: 3.11
. .venv/bin/activate && \
                ./scripts/install_dev_tools.sh -v .venv
No matching download URL found for noobaa on Darwin arm64
Cleaning up temporary files

But it still exits with a 0 status 🤔

[mateusoliveira43]

yeah, that is a known issue #518

try running script directly with for example scripts/install_dev_tools.sh -c operator-sdk -v .venv (I think you need helm and opeartor-sdk for the version script)

[KevinMGranger]

$ ./scripts/update_projects_version.py -f -r
INFO:root:Removing destination folder /Users/kevin/workcode/pelorus/pelorus-operator
ERROR:root:You must be logged in to a OpenShift cluster as a user with cluster-admin permissions to run this script. This avoids RBAC problems. More info: https://sdk.operatorframework.io/docs/building-operators/helm/tutorial/#prerequisites

I don't see why this is necessary, perhaps we should open an issue for this. I'll get my CRC cluster up and running again I suppose.

[mateusoliveira43]

I think there is missing explanation in Operator SDK site, but it is in there prerequisites

maybe with the PR I am working on #1045 we can remove this constrain, but today I believe we need it

[github-actions]

Test images available! 🧪🚀 To test operator with them, run

operator-sdk run bundle \
quay.io/pelorus/rc-pelorus-operator-bundle:vpr823-66f41a1 \
--namespace test-pelorus-operator

To clean up environment afterwards, run

operator-sdk cleanup pelorus-operator --namespace test-pelorus-operator

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@KevinMGranger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.10-e2e-openshift	25f4e0f	link	true	/test 4.10-e2e-openshift
ci/prow/4.13-e2e-openshift	25f4e0f	link	true	/test 4.13-e2e-openshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.