Make daemons working dir configurable #555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haixuanTao
reviewed
Jun 19, 2024
| .ok_or_else(|| eyre::eyre!("canonicalized dataflow path has no parent"))? | ||
| .to_owned(); | ||
| pub async fn run_dataflow(dataflow_path: &Path, working_dir: PathBuf) -> eyre::Result<()> { | ||
| // let working_dir = dataflow_path |
There was a problem hiding this comment.
We shouldn't leave commented code within the codebase.
| @@ -2281,6 +2281,7 @@ name = "dora-coordinator" | |||
| version = "0.3.4" | |||
| dependencies = [ | |||
| "ctrlc", | |||
| "dirs 5.0.1", | |||
There was a problem hiding this comment.
Is this still necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for multiple-daemons:
path check. for a dataflow, if the number of machine > 1, skip all path exist check.
working_dir is configurable in cli, (the default value is "."), so the relative path is allowed again, like:
dora daemon --machine-id A --working-dir examples/rust-dataflowfor local and remote, the working_dir is default "." or specified, not the directory of dataflow.yml. so dora up are also changed, if there are some dataflow running in one daemon(maybe it is inconvenient I think)
dora up --working-dir examples/rust-dataflowthe dynamic node need directory same as dataflow(not sure), so there need more attention.
follow #535