Skip to content
This repository has been archived by the owner on Jan 5, 2025. It is now read-only.

Update .env.template with placeholders #13

Closed
wants to merge 4 commits into from

Conversation

tectonia
Copy link
Contributor

@tectonia tectonia commented Apr 17, 2024

Replaces the following hardcoded vaules in docker/.env.template with placeholders:

  • AZURE_CLIENT_ID,

  • AZURE_CLIENT_SECRET,

  • AZURE_TENANT_ID,

  • DataHubFhirServer__TemplateImage

  • Tests

  • Documentation

@tectonia tectonia self-assigned this Apr 17, 2024
Copy link
Contributor

@liammoat liammoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up 👍

@gaurarpit gaurarpit self-requested a review April 17, 2024 10:28
@gaurarpit
Copy link
Contributor

i am just thinking, they will always now be in the git commit history. so, anyone can go back and look.
I am not blocking this PR and approving it, but, let's chat about this topic. I dont know what the right solution would be. Let's brainstorm.

Copy link
Contributor

@gaurarpit gaurarpit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment that I want to discuss. rest LGTM.

@tectonia
Copy link
Contributor Author

i am just thinking, they will always now be in the git commit history. so, anyone can go back and look. I am not blocking this PR and approving it, but, let's chat about this topic. I dont know what the right solution would be. Let's brainstorm.

Client ID and tenant ID are not secrets per se. They are discoverable knowing domain name to anyone on the internet I believe. @liammoat correct me if I'm wrong please.

@liammoat
Copy link
Contributor

i am just thinking, they will always now be in the git commit history. so, anyone can go back and look. I am not blocking this PR and approving it, but, let's chat about this topic. I dont know what the right solution would be. Let's brainstorm.

Client ID and tenant ID are not secrets per se. They are discoverable knowing domain name to anyone on the internet I believe. @liammoat correct me if I'm wrong please.

Yeah - no major concerns from me with these being in the history.

@tectonia
Copy link
Contributor Author

Unfortunately, the template tests do not succeed with placeholder values. We should investigate further why. I will abandon this PR and raise a work item separately.

@tectonia tectonia closed this Apr 17, 2024
@tectonia tectonia deleted the martyna/feature/30412/modify-env-template branch April 17, 2024 16:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants