This repository has been archived by the owner on Jan 5, 2025. It is now read-only.
feat: support app service certificate store pds integration #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurarpit
reviewed
Apr 17, 2024
gaurarpit
reviewed
Apr 17, 2024
gaurarpit
reviewed
Apr 17, 2024
Co-authored-by: Arpit Gaur <[email protected]>
gaurarpit
reviewed
Apr 17, 2024
Co-authored-by: Arpit Gaur <[email protected]>
Co-authored-by: Arpit Gaur <[email protected]>
Co-authored-by: Arpit Gaur <[email protected]>
gaurarpit
reviewed
Apr 18, 2024
gaurarpit
approved these changes
Apr 18, 2024
|
approved. let's wait for final testing from your in ADO. |
liammoat
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to store PDS certificates as "certificates" in Azure Key Vault. This enables us to load those certificates into the Azure App Service certificate store. From here, they are loaded into the application and read as X509 certs.
Confirmation from development this auth flow works successfully: