Skip to content

Commit

Permalink
[bitnami/common] Do not explicitly specify namespace in affinity term.
Browse files Browse the repository at this point in the history
the current context namespace defined is identical as not defined at all

> null or empty namespaces list and null namespaceSelector means "this pod's namespace"

docs: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.23/#podaffinityterm-v1-core
issue: bitnami#12668
  • Loading branch information
dosmanak committed Oct 12, 2022
1 parent fb170bc commit ab1e03b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 2 additions & 2 deletions bitnami/common/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ annotations:
category: Infrastructure
apiVersion: v2
# Please make sure that version and appVersion are always the same.
appVersion: 2.0.3
appVersion: 2.0.4
description: A Library Helm Chart for grouping common logic between bitnami charts. This chart is not deployable by itself.
home: https://github.com/bitnami/charts/tree/master/bitnami/common
icon: https://bitnami.com/downloads/logos/bitnami-mark.png
Expand All @@ -20,4 +20,4 @@ sources:
- https://github.com/bitnami/charts
- https://www.bitnami.com/
type: library
version: 2.0.3
version: 2.0.4
4 changes: 0 additions & 4 deletions bitnami/common/templates/_affinities.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ preferredDuringSchedulingIgnoredDuringExecution:
{{- range $key, $value := $extraMatchLabels }}
{{ $key }}: {{ $value | quote }}
{{- end }}
namespaces:
- {{ include "common.names.namespace" .context | quote }}
topologyKey: kubernetes.io/hostname
weight: 1
{{- end -}}
Expand All @@ -84,8 +82,6 @@ requiredDuringSchedulingIgnoredDuringExecution:
{{- range $key, $value := $extraMatchLabels }}
{{ $key }}: {{ $value | quote }}
{{- end }}
namespaces:
- {{ include "common.names.namespace" .context | quote }}
topologyKey: kubernetes.io/hostname
{{- end -}}

Expand Down

0 comments on commit ab1e03b

Please sign in to comment.