#29618: making secure fallback option when no issue is provided (#29892

)
dotCMS · Sep 5, 2024 · c72f6d4 · c72f6d4
1 parent 96bc278
commit c72f6d4
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/.github/workflows/issue_comp_next-release-label.yml b/.github/workflows/issue_comp_next-release-label.yml
@@ -58,15 +58,20 @@ jobs:
                 });
             }
             
-            let issueNumber = ('${{ inputs.issue_number }}'.trim() && parseInt('${{ inputs.issue_number }}')) || -1;
-            const issue = context.payload.issue || await getIssue(issueNumber);
+            let issue = context.payload.issue;
             if (!issue) {
+              if (!!'${{ inputs.issue_number }}') {
+                issue = await getIssue(${{ inputs.issue_number }});
+              }
+            
+              if (!issue) {
                 console.log('Issue [${{ inputs.issue_number }}] not found');
                 process.exit(0);
+              }
             }
             
             console.log(`Issue: ${JSON.stringify(issue, null, 2)}`);
-            issueNumber = issue.data.number;
+            const issueNumber = issue.data.number;
             
             const dropAndLearnText = 'Drop Everything & Learn';
             if (issue.data.title.includes(dropAndLearnText)) {