Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Contentlet: Allow user to upload files from external sources #26047

Closed
Tracked by #25445
rjvelazco opened this issue Sep 11, 2023 · 5 comments · Fixed by #26313
Closed
Tracked by #25445

Edit Contentlet: Allow user to upload files from external sources #26047

rjvelazco opened this issue Sep 11, 2023 · 5 comments · Fixed by #26313
Assignees
@rjvelazco
Labels
OKR : User Experience Owned by Jason Priority : 3 Average QA : Approved Team : Lunik Type : Task

Comments

@rjvelazco
Copy link
Contributor

rjvelazco commented Sep 11, 2023 •
edited
Loading

Parent Issue

#25445

Task

As a dotCMS user, I want to be able to upload files from external sources by copying/pasting the URL.

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

Acceptance Criteria

  • Allow the user to upload files from external sources
  • Handle Invalid URL errors.
  • Handle server errors that may occur during the upload or publication of the workflow action.

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

allow the user to upload files from external sources

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
This was referenced Sep 11, 2023
Open
Closed
@fmontes fmontes changed the title Content Edit Refactor: Allow user to upload files from external sources Edit Contentlet: Allow user to upload files from external sources Sep 18, 2023
@rjvelazco rjvelazco self-assigned this Sep 27, 2023
@rjvelazco rjvelazco moved this from New to In Progress in dotCMS - Product Planning Sep 27, 2023
@rjvelazco rjvelazco mentioned this issue Sep 28, 2023
Merged
2 tasks
@rjvelazco rjvelazco moved this from In Progress to In Review in dotCMS - Product Planning Oct 4, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in dotCMS - Product Planning Oct 6, 2023
@fmontes fmontes moved this from Done to Internal QA in dotCMS - Product Planning Oct 6, 2023
@KevinDavilaDotCMS
Copy link
Contributor

Pass internal QA

Tested on master

Screen.Recording.2023-10-09.at.12.45.20.mov

@KevinDavilaDotCMS KevinDavilaDotCMS moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Oct 9, 2023
@bryanboza bryanboza moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning Oct 10, 2023
@josemejias11 josemejias11 reopened this Oct 10, 2023
@github-project-automation github-project-automation bot moved this from QA - In Progress to Current Sprint Backlog in dotCMS - Product Planning Oct 10, 2023
@bryanboza bryanboza moved this from Current Sprint Backlog to QA - In Progress in dotCMS - Product Planning Oct 10, 2023
@josemejias11
Copy link
Contributor

josemejias11 commented Oct 10, 2023 •
edited
Loading

Failed: Tested on master_efcccfc_SNAPSHOT, Docker, macOS 13.0, FF v113.0

Screen.Recording.2023-10-10.at.11.47.40.AM.mov

Seems that we are able to import anything and everything we try to upload to the binary field. Should we have a checklist of posible allow files to handle?

@josemejias11 josemejias11 moved this from QA - In Progress to QA - Rejected in dotCMS - Product Planning Oct 10, 2023
@fmontes
Copy link
Member

fmontes commented Oct 12, 2023

Binary will take everything... you can limit what it takes using field variables https://www.dotcms.com/docs/latest/binary-field#FieldVariables

@fmontes fmontes moved this from QA - Rejected to QA - Backlog in dotCMS - Product Planning Oct 12, 2023
@rjvelazco
Copy link
Contributor Author

rjvelazco commented Oct 13, 2023 •
edited
Loading

@josemejias11 We do have a field variable called accept that you can configure in the binary field for that. The problem is that the backend does not validate that yet and is not returning the extension/mimeType to validate in the Front-end when you upload a file using the temp API by URL endpoint. We have a ticket for that: #26340

@josemejias11
Copy link
Contributor

Approved: Tested on master_534774e_SNAPSHOT, Docker, macOS 13.0, FF v113.0

@josemejias11 josemejias11 moved this from QA - Backlog to Done in dotCMS - Product Planning Oct 13, 2023
@fmontes fmontes closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjvelazco rjvelazco

Labels
OKR : User Experience Owned by Jason Priority : 3 Average QA : Approved Team : Lunik Type : Task
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Edit Contentlet: Allow user to upload files from external sources dotCMS/core
7 participants
@fmontes @bryanboza @victoralfaro-dotcms @rjvelazco @damen-dotcms @josemejias11 @KevinDavilaDotCMS