Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Virtual Scroll to load 6k sites #28843

Closed
Tracked by #28494
nicobytes opened this issue Jun 11, 2024 · 3 comments · Fixed by #28850 or #28905
Closed
Tracked by #28494

Implement Virtual Scroll to load 6k sites #28843

nicobytes opened this issue Jun 11, 2024 · 3 comments · Fixed by #28850 or #28905

Comments

@nicobytes
Copy link
Contributor

nicobytes commented Jun 11, 2024

Parent Issue

#28494

Current behavior

The actual field when there are more than 6k sites is so slow and the TreeSelect does not work well, the idea is to clone the TreeSelect and implement virtual scrolling to avoid this behavior.

Video Support

video.mp4

Steps for IQA

  1. Ask Nicolas Molina or Daniel Silva for a db with 7k sites.
  2. Load this db into your docker db
# Copy the db to your container
docker cp ./wth.sql postgres-dotcms:./
# Load this db
docker exec -it postgres-dotcms psql -U dotcms -f ./wth.sql <your_db>
  1. Enable DOT_FEATURE_FLAG_NEW_EDIT_PAGE in your docker compose.

Screenshot 2024-06-17 at 12 10 45 PM

  1. Create a new content type using the new editor content

Screenshot 2024-06-17 at 12 12 10 PM

  1. Add a SiteOrFolder field

Screenshot 2024-06-17 at 12 08 03 PM

  1. Test this field by creating new content based on this schema

Screenshot 2024-06-17 at 12 13 24 PM

@nicobytes nicobytes self-assigned this Jun 11, 2024
@nicobytes nicobytes moved this from New to In Progress in dotCMS - Product Planning Jun 11, 2024
@nicobytes nicobytes linked a pull request Jun 11, 2024 that will close this issue
3 tasks
@nicobytes nicobytes moved this from In Progress to In Review in dotCMS - Product Planning Jun 13, 2024
@nicobytes nicobytes moved this from In Review to Internal QA in dotCMS - Product Planning Jun 14, 2024
@dsilvam dsilvam reopened this Jun 17, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Jun 17, 2024
@dsilvam dsilvam moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Jun 17, 2024
@dsilvam
Copy link
Contributor

dsilvam commented Jun 17, 2024

Internal QA: Needs work.

When scrolling down, the scroll bar indicator gets lost when approaching the bottom/end.
When scrolling back up, the scroll bar indicator gets lost when approaching the top/beginning.

Screen.Recording.2024-06-17.at.11.39.26.AM.mov

@dsilvam dsilvam moved this from Internal QA to In Progress in dotCMS - Product Planning Jun 17, 2024
@dsilvam dsilvam assigned dsilvam and nicobytes and unassigned dsilvam Jun 17, 2024
@nicobytes nicobytes linked a pull request Jun 17, 2024 that will close this issue
3 tasks
@nicobytes nicobytes moved this from In Progress to In Review in dotCMS - Product Planning Jun 17, 2024
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Jun 17, 2024
@github-actions github-actions bot mentioned this issue Jun 17, 2024
3 tasks
@dsilvam dsilvam reopened this Jun 18, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Jun 18, 2024
@dsilvam dsilvam moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Jun 18, 2024
@dsilvam dsilvam assigned dsilvam and unassigned nicobytes Jun 18, 2024
@dsilvam
Copy link
Contributor

dsilvam commented Jun 18, 2024

Passed Internal QA: Scrolling issue reported above not happening anymore.

@dsilvam dsilvam closed this as completed Jun 18, 2024
@dsilvam dsilvam moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Jun 18, 2024
@bryanboza bryanboza moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning Jun 18, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on trunk_f319f84, Docker, macOS 14.5, FF v126.0.1

@josemejias11 josemejias11 moved this from QA - In Progress to Done in dotCMS - Product Planning Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment