Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with scroll #28905

Merged
merged 6 commits into from
Jun 17, 2024
Merged

Fix bug with scroll #28905

merged 6 commits into from
Jun 17, 2024

Conversation

nicobytes
Copy link
Contributor

@nicobytes nicobytes commented Jun 17, 2024

Proposed Changes

  • Add scrollHeight input to fix error and match with VirtualScroll Height

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Videos

Original

Screen.Recording.2024-06-17.at.11.39.26.AM.mov

Updated

2024-06-17.16-09-47.mp4

This PR fixes: #28843

@nicobytes nicobytes linked an issue Jun 17, 2024 that may be closed by this pull request
@nicobytes nicobytes self-assigned this Jun 17, 2024
@nicobytes nicobytes requested a review from rjvelazco June 17, 2024 20:46
@nicobytes nicobytes enabled auto-merge June 17, 2024 20:50
Copy link

@nicobytes nicobytes added this pull request to the merge queue Jun 17, 2024
Merged via the queue into master with commit 9384d32 Jun 17, 2024
16 checks passed
@nicobytes nicobytes deleted the 28843-fix-scroll branch June 17, 2024 23:34
oidacra pushed a commit that referenced this pull request Jun 26, 2024
### Proposed Changes
* Add scrollHeight input to fix error and match with VirtualScroll
Height

### Checklist
- [x] Tests
- [x] Translations
- [x] Security Implications Contemplated (add notes if applicable)


### Videos

Original       


https://github.com/dotCMS/core/assets/7611944/ac4dbedc-ea09-427b-b090-002fd70654ad

Updated


https://github.com/dotCMS/core/assets/7611944/ff14c0d0-34ba-4fa3-8c29-a1cab5dbd03c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Virtual Scroll to load 6k sites
4 participants