Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error publishing a page from variant editing: "Bad request error" #30726

Closed
bryanboza opened this issue Nov 20, 2024 · 4 comments · Fixed by #31001
Closed

Error publishing a page from variant editing: "Bad request error" #30726

bryanboza opened this issue Nov 20, 2024 · 4 comments · Fixed by #31001

Comments

@bryanboza
Copy link
Member

bryanboza commented Nov 20, 2024

Problem Statement

When attempting to publish a page from the variant editing interface, users encounter a Bad request error. The error message indicates that the content is not in a new, live, or working version, and as a result, the page cannot be published. This issue disrupts workflows for content creators and administrators who rely on variant editing for managing and publishing pages. It prevents the successful publication of pages, impacting website updates and user experience.

image

Steps to Reproduce

  • Log into the dotCMS backend.
  • Navigate to the Variant Editing section.
  • Edit an existing page variant.
  • Attempt to publish the page from the variant editing interface.
  • Observe the error message

Acceptance Criteria

Ensure that pages can be successfully published from the variant editing interface without encountering the error.

dotCMS Version

Tested on the latest agile release // Docker // FF

Proposed Objective

Quality Assurance

Proposed Priority

Priority 2 - Important

@bryanboza
Copy link
Member Author

Note for IQA: Make sure the case exist in: https://github.com/dotCMS/core/blob/main/docs/test-cases/Experiments.csv if not please add a new line.

@nollymar nollymar moved this from New to Next 1-3 Sprints in dotCMS - Product Planning Dec 3, 2024
@valentinogiardino valentinogiardino self-assigned this Dec 11, 2024
@nollymar nollymar moved this from Next 1-3 Sprints to In Progress in dotCMS - Product Planning Dec 13, 2024
Copy link

@valentinogiardino valentinogiardino moved this from In Progress to In Review in dotCMS - Product Planning Dec 20, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 23, 2024
…30726 (#31001)

### Proposed Changes
* Conditionally render the `<dot-uve-workflow-actions>` component in the
`EditEmaToolbarComponent` when `isDefaultVariant` is true.
* Update the `ToolbarProps` model to include the `isDefaultVariant`
property.

### Checklist
- [x] Tests
- [x] Translations
- [x] Security Implications Contemplated (add notes if applicable)

### Additional Info
The `isDefaultVariant` property determines whether the current page
variant is the default. The `<dot-uve-workflow-actions>` component is
displayed only when this condition is met, preventing errors from
triggering workflow actions on variant editing pages.

**Slack conversation:**
https://dotcms.slack.com/archives/CQMHM7PNJ/p1734635875445969

### Screenshots
#### Before


https://github.com/user-attachments/assets/f1d938e7-4dca-4fd4-a7aa-89872bb15be9

#### After


https://github.com/user-attachments/assets/b8d0a20a-04de-4e51-acd8-59b766198255
@github-project-automation github-project-automation bot moved this from In Review to Done in dotCMS - Product Planning Dec 23, 2024
@github-project-automation github-project-automation bot moved this from Done to Current Sprint Backlog in dotCMS - Product Planning Dec 23, 2024
@valentinogiardino valentinogiardino moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Dec 23, 2024
@valentinogiardino valentinogiardino removed their assignment Dec 23, 2024
@zJaaal zJaaal self-assigned this Dec 26, 2024
@valentinogiardino
Copy link
Contributor

NOTE TO QA

After discussing in this conversation https://dotcms.slack.com/archives/CQMHM7PNJ/p1734635875445969, we agreed to simply hide the WF action button from the toolbar when editing the variant of an experiment.

@zJaaal
Copy link
Contributor

zJaaal commented Dec 26, 2024

IQA Passed

Now we are hiding the button when editing variants on the old toolbar

For architectural reasons, we couldn't add this fix on the new toolbar, but we will address this behavior in this ticket #30940

We are still on development phase and this must be addressed before releasing the new toolbar.

DotCMS Docker Image: [dotcms/dotcms:trunk_01742fb]

Screenshot

Screen.Recording.2024-12-26.at.2.35.54.PM.mov

@zJaaal zJaaal closed this as completed Dec 26, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Done in dotCMS - Product Planning Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants