fix(uve): Hide workflow actions toolbar button when editing a variant #30726 #31001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinogiardino
requested review from
rjvelazco,
zJaaal,
KevinDavilaDotCMS,
fmontes,
oidacra,
nicobytes and
hmoreras
|
@rjvelazco @KevinDavilaDotCMS we have to port this fix to the new toolbar |
…iant-editing-bad-request-error
rjvelazco
approved these changes
Dec 23, 2024
KevinDavilaDotCMS
approved these changes
Dec 23, 2024
zJaaal
approved these changes
Dec 23, 2024
valentinogiardino
deleted the
issue-30726-error-publishing-a-page-from-variant-editing-bad-request-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
<dot-uve-workflow-actions>component in theEditEmaToolbarComponentwhenisDefaultVariantis true.ToolbarPropsmodel to include theisDefaultVariantproperty.Checklist
Additional Info
The
isDefaultVariantproperty determines whether the current page variant is the default. The<dot-uve-workflow-actions>component is displayed only when this condition is met, preventing errors from triggering workflow actions on variant editing pages.Slack conversation: https://dotcms.slack.com/archives/CQMHM7PNJ/p1734635875445969
Screenshots
Before
variant-wf-action-error.mp4
After
pr-hide-wf-action-button-variant.mp4
This PR fixes: #30726