Content Edit: Implement Monaco Editor #25955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjvelazco
requested review from
fmontes,
oidacra,
manuelrojas,
hmoreras and
zJaaal
hmoreras
reviewed
Sep 1, 2023
hmoreras
approved these changes
Sep 1, 2023
zJaaal
requested changes
Sep 1, 2023
core-web/libs/contenttype-fields/src/lib/fields/binary-field/binary-field.component.html
Outdated
Show resolved
Hide resolved
core-web/libs/contenttype-fields/src/lib/fields/binary-field/binary-field.component.ts
Outdated
Show resolved
Hide resolved
zJaaal
approved these changes
Sep 1, 2023
fmontes
requested changes
Sep 1, 2023
core-web/libs/contenttype-fields/src/lib/fields/binary-field/binary-field.component.ts
Outdated
Show resolved
Hide resolved
core-web/libs/contenttype-fields/src/lib/fields/binary-field/binary-field.component.spec.ts
Outdated
Show resolved
Hide resolved
zJaaal
approved these changes
Sep 5, 2023
oidacra
approved these changes
Sep 5, 2023
|
SonarQube Quality Gate
|
|
SonarQube Quality Gate
|
fmontes
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Description
🤖 Generated by Copilot at 0fc6bc6
Added a code editor feature to the
binary-fieldcomponent. This feature allows the user to write custom code for the binary field in a dialog. The changes include the component template, style, test, story and ts files.Related Issue
Fixes #25946
Explanation of Changes
🤖 Generated by Copilot at 0fc6bc6
Screenshot
issue-25946-content-edit-implement-monaco-editor-fix.mov