Content Edit: Allow Drag&Drop and select file #26077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lect-file' of github.com:dotCMS/core into issue-26048-content-edit-refactor-allow-dragdrop-and-select-file
…agdrop-and-select-file
rjvelazco
requested review from
zJaaal,
fmontes,
oidacra and
KevinDavilaDotCMS
zJaaal
requested changes
Sep 20, 2023
core-web/libs/contenttype-fields/src/lib/fields/binary-field/binary-field.component.html
Outdated
Show resolved
Hide resolved
core-web/libs/contenttype-fields/src/lib/fields/binary-field/binary-field.component.scss
Outdated
Show resolved
Hide resolved
core-web/libs/contenttype-fields/src/lib/fields/binary-field/binary-field.component.ts
Outdated
Show resolved
Hide resolved
core-web/libs/ui/src/lib/components/dot-drop-zone/dot-drop-zone.component.ts
Show resolved
Hide resolved
dotCMS/src/main/webapp/html/js/dotcms/dijit/form/FileAjaxUploader.jsp
Outdated
Show resolved
Hide resolved
zJaaal
requested changes
Sep 21, 2023
core-web/libs/contenttype-fields/src/lib/fields/binary-field/store/binary-field.store.ts
Outdated
Show resolved
Hide resolved
fmontes
requested changes
Sep 21, 2023
...e-fields/src/lib/fields/binary-field/components/dot-ui-message/dot-ui-message.component.scss
Outdated
Show resolved
Hide resolved
...e-fields/src/lib/fields/binary-field/components/dot-ui-message/dot-ui-message.component.scss
Outdated
Show resolved
Hide resolved
core-web/libs/contenttype-fields/src/lib/fields/binary-field/binary-field.component.ts
Show resolved
Hide resolved
dotCMS/src/main/webapp/html/portlet/ext/contentlet/edit_contentlet.jsp
Outdated
Show resolved
Hide resolved
zJaaal
reviewed
Sep 21, 2023
| ).nativeElement; | ||
| const file = new File(['test'], 'test.png', { type: 'image/png' }); | ||
| const event = new Event('change'); | ||
| Object.defineProperty(event, 'target', { value: { files: [file] } }); |
…agdrop-and-select-file
zJaaal
approved these changes
Sep 21, 2023
fmontes
approved these changes
Sep 22, 2023
fmontes
changed the title
…agdrop-and-select-file
…agdrop-and-select-file
…agdrop-and-select-file
|
SonarQube Quality Gate
|
|
SonarQube Quality Gate
|
fmontes
deleted the
issue-26048-content-edit-refactor-allow-dragdrop-and-select-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Description
🤖 Generated by Copilot at 3147ad4
This pull request introduces a new binary field component that allows users to upload files to dotCMS. The component uses a
dot-drop-zonecomponent and adot-drop-zone-messagecomponent to handle the file selection and validation. The pull request also updates the storybook, the styles, the tests, and the messages for the binary field component and its related components. The pull request modifies the filesbinary-field.component.*,dot-drop-zone.component.*,dot-drop-zone-message.component.*,binary-field-utils.ts,mock.ts,button.scss,index.ts, andLanguage.properties.Related Issue
Fixes #26048
Explanation of Changes
🤖 Generated by Copilot at 3147ad4
DotDropZoneComponentand theDotDropZoneMessageComponentfrom the ui library and declared them as dependencies for the binary field component in the storybook (link, link, link)DropZoneFileValidityinterface to add the errorType property, which provides a more specific error type for the file validity (link)Screenshots
fix-issue-26048-content-edit-refactor-allow-dragdrop-and-select-file.mov