Fix #26442: Edit Contentlet Add Text Area and enhance Text Field #26446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtarea-field-to-the-form
…xtarea-field-to-the-form
fmontes
requested changes
Oct 18, 2023
...s/edit-content/src/lib/components/dot-edit-content-field/dot-edit-content-field.component.ts
Outdated
Show resolved
Hide resolved
...s/edit-content/src/lib/components/dot-edit-content-form/dot-edit-content-form.component.scss
Show resolved
Hide resolved
...s/edit-content/src/lib/components/dot-edit-content-form/dot-edit-content-form.component.scss
Outdated
Show resolved
Hide resolved
...it-content/src/lib/fields/dot-edit-content-text-area/dot-edit-content-text-area.component.ts
Show resolved
Hide resolved
...-content/src/lib/fields/dot-edit-content-text-area/dot-edit-content-text-area.component.html
Outdated
Show resolved
Hide resolved
...ntent/src/lib/fields/dot-edit-content-text-area/dot-edit-content-text-area.component.spec.ts
Outdated
Show resolved
Hide resolved
...ntent/src/lib/fields/dot-edit-content-text-area/dot-edit-content-text-area.component.spec.ts
Outdated
Show resolved
Hide resolved
...-content/src/lib/fields/dot-edit-content-text-field/dot-edit-content-text-field.component.ts
Outdated
Show resolved
Hide resolved
...ent/src/lib/fields/dot-edit-content-text-field/dot-edit-content-text-field.component.spec.ts
Outdated
Show resolved
Hide resolved
|
…xtarea-field-to-the-form
…xtarea-field-to-the-form
oidacra
reviewed
Oct 19, 2023
core-web/libs/edit-content/src/lib/fields/dot-edit-content-fields.module.ts
Show resolved
Hide resolved
oidacra
reviewed
Oct 19, 2023
...s/edit-content/src/lib/components/dot-edit-content-field/dot-edit-content-field.component.ts
Outdated
Show resolved
Hide resolved
hmoreras
approved these changes
Oct 19, 2023
…xtarea-field-to-the-form
fmontes
requested changes
Oct 20, 2023
...edit-content/src/lib/components/dot-edit-content-field/dot-edit-content-field.component.html
Outdated
Show resolved
Hide resolved
core-web/libs/edit-content/src/lib/components/dot-edit-content-field/utils.ts
Show resolved
Hide resolved
...t-content/src/lib/components/dot-edit-content-field/dot-edit-content-field.component.spec.ts
Show resolved
Hide resolved
...s/edit-content/src/lib/components/dot-edit-content-form/dot-edit-content-form.component.scss
Outdated
Show resolved
Hide resolved
...s/edit-content/src/lib/components/dot-edit-content-form/dot-edit-content-form.component.scss
Outdated
Show resolved
Hide resolved
...ntent/src/lib/fields/dot-edit-content-text-area/dot-edit-content-text-area.component.spec.ts
Show resolved
Hide resolved
|
SonarQube Quality Gate
|
fmontes
approved these changes
Oct 20, 2023
KevinDavilaDotCMS
approved these changes
Oct 20, 2023
fmontes
deleted the
26442-edit-content-render-textfield-and-textarea-field-to-the-form
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 10ae5dd
Summary
🎨🚧🧪
Refactored the edit content field component to use custom components for text fields and textarea fields. Updated the unit tests and styles for the edit content field and form components. Added new files for the text field and textarea components and their models.
Walkthrough
DotEditContentTextFieldComponentandDotEditContentTextAreaComponent, to handle the logic and styles for different field types in the edit content form (F8-F15, F16).Screenshots
Screen.Recording.2023-10-17.at.6.23.47.PM.mov