Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TreeSelect to storybook #28666

Merged
merged 15 commits into from
May 29, 2024
Merged

Add TreeSelect to storybook #28666

merged 15 commits into from
May 29, 2024

Conversation

nicobytes
Copy link
Contributor

@nicobytes nicobytes commented May 24, 2024 •
edited
Loading

Parent Issue

#28494

Proposed Changes

Add Support to TreeSelect Component to StoryBook.

Additional Info

This component is based on based TreeSelect Component by PrimeNG.

Screenshots
Basic Invalid
localhost_4400__path=story_primeng-form-treeselect--default globals=backgrounds value!hex(F8F8F8);backgrounds grid_!false (1) localhost_4400__path=story_primeng-form-treeselect--default globals=backgrounds value!hex(F8F8F8);backgrounds grid_!false (2)
With Label With float label
localhost_4400__path=story_primeng-form-treeselect--default globals=backgrounds value!hex(F8F8F8);backgrounds grid_!false (3) localhost_4400__path=story_primeng-form-treeselect--default globals=backgrounds value!hex(F8F8F8);backgrounds grid_!false (5)
Disabled Multiple Choice
localhost_4400__path=story_primeng-form-treeselect--default globals=backgrounds value!hex(F8F8F8);backgrounds grid_!false (6) localhost_4400__path=story_primeng-form-treeselect--default globals=backgrounds value!hex(F8F8F8);backgrounds grid_!false (7)
Checkboxes Search
localhost_4400__path=story_primeng-form-treeselect--default globals=backgrounds value!hex(F8F8F8);backgrounds grid_!false (8) localhost_4400__path=story_primeng-form-treeselect--default globals=backgrounds value!hex(F8F8F8);backgrounds grid_!false (9)
Not found
localhost_4400__path=story_primeng-form-treeselect--default globals=backgrounds value!hex(F8F8F8);backgrounds grid_!false (10)

@nicobytes nicobytes changed the title Issue 28638 add treeselect to storybook Add treeselect to storybook May 24, 2024
@nicobytes nicobytes changed the title Add treeselect to storybook Add TreeSelect to storybook May 24, 2024
@nicobytes nicobytes marked this pull request as draft May 24, 2024 21:20
@nicobytes nicobytes linked an issue May 28, 2024 that may be closed by this pull request
Implement PrimeNg Treeselect in Storybook, implement the design system #28638
Closed
@nicobytes nicobytes marked this pull request as ready for review May 28, 2024 19:46
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@nicobytes nicobytes dismissed zJaaal’s stale review May 29, 2024 15:43

I already solve the issues

@nicobytes nicobytes added this pull request to the merge queue May 29, 2024
@nicobytes nicobytes mentioned this pull request May 29, 2024
Closed
Merged via the queue into master with commit 39cd937 May 29, 2024
27 checks passed
@nicobytes nicobytes deleted the issue-28638-add-treeselect-to-storybook branch May 29, 2024 18:10
spbolton pushed a commit that referenced this pull request Jun 3, 2024
@nicobytes @spbolton
Add TreeSelect to storybook (#28666)
b79052a 
### Parent Issue

#28494

### Proposed Changes

Add Support to TreeSelect Component to StoryBook.

### Additional Info

This component is based on based
[TreeSelect](https://www.primefaces.org/primeng-v15-lts/treeselect)
Component by PrimeNG.

### Screenshots

| | |
|--------|--------|
| Basic | Invalid |
| ![localhost_4400__path=_story_primeng-form-treeselect--default
globals=backgrounds value_!hex(F8F8F8);backgrounds grid_!false
(1)](https://github.com/dotCMS/core/assets/7611944/1f70b3d4-7443-4e3f-8fc1-9f79e7ee8896)
| ![localhost_4400__path=_story_primeng-form-treeselect--default
globals=backgrounds value_!hex(F8F8F8);backgrounds grid_!false
(2)](https://github.com/dotCMS/core/assets/7611944/e782779d-a4be-478d-b124-46fe5c5e0e58)
|
| With Label | With float label |
| ![localhost_4400__path=_story_primeng-form-treeselect--default
globals=backgrounds value_!hex(F8F8F8);backgrounds grid_!false
(3)](https://github.com/dotCMS/core/assets/7611944/cd223b8e-d740-4121-bc14-cb1e352dfc84)
| ![localhost_4400__path=_story_primeng-form-treeselect--default
globals=backgrounds value_!hex(F8F8F8);backgrounds grid_!false
(5)](https://github.com/dotCMS/core/assets/7611944/be3b04a0-a60b-47ca-b411-d35b54e02254)
|
| Disabled | Multiple Choice |
| ![localhost_4400__path=_story_primeng-form-treeselect--default
globals=backgrounds value_!hex(F8F8F8);backgrounds grid_!false
(6)](https://github.com/dotCMS/core/assets/7611944/12837c61-fad0-458e-843f-17019a9137b2)
| ![localhost_4400__path=_story_primeng-form-treeselect--default
globals=backgrounds value_!hex(F8F8F8);backgrounds grid_!false
(7)](https://github.com/dotCMS/core/assets/7611944/ccab3f9c-2acd-4734-b271-d8a1c54e7af7)
|
| Checkboxes | Search |
| ![localhost_4400__path=_story_primeng-form-treeselect--default
globals=backgrounds value_!hex(F8F8F8);backgrounds grid_!false
(8)](https://github.com/dotCMS/core/assets/7611944/c13bb166-3083-4058-bb2f-638382dc080a)
| ![localhost_4400__path=_story_primeng-form-treeselect--default
globals=backgrounds value_!hex(F8F8F8);backgrounds grid_!false
(9)](https://github.com/dotCMS/core/assets/7611944/bb020f69-5e38-477f-b80f-cb570404c9ec)
|
| Not found | |
| ![localhost_4400__path=_story_primeng-form-treeselect--default
globals=backgrounds value_!hex(F8F8F8);backgrounds grid_!false
(10)](https://github.com/dotCMS/core/assets/7611944/173b9b3e-ee69-4a1d-aa1e-7193addb5773)
| |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinDavilaDotCMS KevinDavilaDotCMS KevinDavilaDotCMS left review comments

@zJaaal zJaaal zJaaal approved these changes

@oidacra oidacra oidacra approved these changes

@fmontes fmontes fmontes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement PrimeNg Treeselect in Storybook, implement the design system
5 participants
@nicobytes @fmontes @oidacra @zJaaal @KevinDavilaDotCMS