Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task(dev) update dev docker image to use java 21 #29831

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

wezell
Copy link
Contributor

@wezell wezell commented Aug 31, 2024

ref: #29830

The dev image was unable to use the minified /java version that we ship with the dotcms image because it was missing some packages that are needed by opensearch to run.

This PR fixes: #29830

@wezell wezell linked an issue Aug 31, 2024 that may be closed by this pull request
Copy link
Contributor

@spbolton spbolton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not perfect, as the java used here will not keep in sync with the .sdkmanrc version. This should not be a problem until we need to upgrade beyond java 21, but do need to be able to accept that this will automatically pull in the latest ms java 21 version and can change between builds if a new one is pushed, we do not have explicit testing of this image so may not find issues, but seeing we provide this as-is it is not as much of a problem. It would have been nice if we could have the same base image and did not have so much custom code in here that potentially could be broken by other underlying changes without realizing their impact on this Dockerfile. We need this fixed now so I am fine with this current change.

@nollymar nollymar added this pull request to the merge queue Sep 2, 2024
Merged via the queue into master with commit cc63b1d Sep 2, 2024
16 checks passed
@nollymar nollymar deleted the issue-29830-dev-image-java-21 branch September 2, 2024 18:24
dsolistorres pushed a commit that referenced this pull request Sep 18, 2024
ref: #29830


The dev image was unable to use the minified `/java` version that we
ship with the dotcms image because it was missing some packages that are
needed by opensearch to run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move dev image to java 21
3 participants