fix(edit-content-type) check it out in WYSIWYG field has broken styles #27341 #30250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinogiardino
requested review from
fmontes,
oidacra,
nicobytes,
hmoreras,
rjvelazco and
KevinDavilaDotCMS
|
oidacra
approved these changes
Oct 4, 2024
hmoreras
approved these changes
Oct 4, 2024
valentinogiardino
deleted the
issue-27341-check-it-out-button-in-editing-a-wysiwyg-field-has-broken-styles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
dot-convert-to-block-info.component.htmltemplate to use thelabelproperty of PrimeNGpButtoninstead of manually setting the button label inside the button element.ButtonModulefrom PrimeNG in thedot-convert-to-block-info.component.spec.tsto properly support thepButtondirective and itslabelproperty in tests.Checklist
Additional Info
This update ensures that the
pButtondirective from PrimeNG correctly handles the button label by using thelabelproperty, allowing for more maintainable and PrimeNG-compliant code. Previously, the button label was manually rendered inside the button, which lead to styling issues.Screenshots
This PR fixes: #27341