Issue 30291 osgi actionlet reinit failure #30292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcastro-dotcms
approved these changes
Oct 8, 2024
wezell
force-pushed
the
issue-30291-osgi-actionlet-reinit-failure
branch
from
55fc7f8 to
87f5447
Compare
|
erickgonzalez
approved these changes
Oct 9, 2024
swicken-dotcms
approved these changes
Oct 9, 2024
spbolton
pushed a commit
that referenced
this pull request
Nov 11, 2024
This pull request forces OSGI to init BEFORE an actionlet is registered. It changes to the `WorkflowAPIImpl` class to improve OSGI initialization and error handling. The most important changes include adding a new import for `OSGIUtil`, modifying the `registerBundleService` method to ensure OSGI is initialized, and adding error handling for null `BundleContext`. ### Improvements to OSGI Initialization and Error Handling: * [`dotCMS/src/main/java/com/dotmarketing/portlets/workflows/business/WorkflowAPIImpl.java`](diffhunk://#diff-5a5ef615df4ac7495073609cffd31eabd85513c4c81dd48cc82b5c6fd0523934R143): Added import for `org.apache.felix.framework.OSGIUtil`. * [`dotCMS/src/main/java/com/dotmarketing/portlets/workflows/business/WorkflowAPIImpl.java`](diffhunk://#diff-5a5ef615df4ac7495073609cffd31eabd85513c4c81dd48cc82b5c6fd0523934L370-R387): Modified `registerBundleService` method to initialize OSGI framework and added error handling for cases where OSGI is not initialized or `BundleContext` is null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request forces OSGI to init BEFORE an actionlet is registered. It changes to the
WorkflowAPIImplclass to improve OSGI initialization and error handling. The most important changes include adding a new import forOSGIUtil, modifying theregisterBundleServicemethod to ensure OSGI is initialized, and adding error handling for nullBundleContext.Improvements to OSGI Initialization and Error Handling:
dotCMS/src/main/java/com/dotmarketing/portlets/workflows/business/WorkflowAPIImpl.java: Added import fororg.apache.felix.framework.OSGIUtil.dotCMS/src/main/java/com/dotmarketing/portlets/workflows/business/WorkflowAPIImpl.java: ModifiedregisterBundleServicemethod to initialize OSGI framework and added error handling for cases where OSGI is not initialized orBundleContextis null.This PR fixes: #30291