Fix (CLI): Fixed flaky test ContentTypeCommandIT.Test_Command_Content_Type_Folder_Push #30304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… server time to process and index the new content types.
…laky-test-ContentTypeCommandIT-Test_Command_Content_Type_Folder_Push
valentinogiardino
approved these changes
Oct 9, 2024
|
jgambarios
deleted the
issue-30280-CLI-Fix-flaky-test-ContentTypeCommandIT-Test_Command_Content_Type_Folder_Push
branch
spbolton
pushed a commit
that referenced
this pull request
Nov 11, 2024
…_Type_Folder_Push (#30304) This pull request updates the `createContentTypeOnServer` method in the `ContentTypesTestHelperService` class to improve content type creation and validation. The most important changes include removing unused variables and adding a validation step to ensure the content type is created successfully. Codebase simplification and validation improvement: * [`tools/dotcms-cli/cli/src/test/java/com/dotcms/cli/common/ContentTypesTestHelperService.java`](diffhunk://#diff-aec7feeb63a6f9ad6aa941eff561882f257837e0a706ad26fe2625b0355ee3d5L66-L68): Removed unused variables `identifier` and `varName` from the `createContentTypeOnServer` method. * [`tools/dotcms-cli/cli/src/test/java/com/dotcms/cli/common/ContentTypesTestHelperService.java`](diffhunk://#diff-aec7feeb63a6f9ad6aa941eff561882f257837e0a706ad26fe2625b0355ee3d5L77-R79): Added a validation step to check if the content type is created successfully and throw an exception if not found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
createContentTypeOnServermethod in theContentTypesTestHelperServiceclass to improve content type creation and validation. The most important changes include removing unused variables and adding a validation step to ensure the content type is created successfully.Codebase simplification and validation improvement:
tools/dotcms-cli/cli/src/test/java/com/dotcms/cli/common/ContentTypesTestHelperService.java: Removed unused variablesidentifierandvarNamefrom thecreateContentTypeOnServermethod.tools/dotcms-cli/cli/src/test/java/com/dotcms/cli/common/ContentTypesTestHelperService.java: Added a validation step to check if the content type is created successfully and throw an exception if not found.This PR fixes: #30280