Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UVE): UrlContentMap Redirection to Correct Page After Save or Publish #29896 #30334

Merged
merged 6 commits into from
Oct 15, 2024

Conversation

valentinogiardino
Copy link
Contributor

@valentinogiardino valentinogiardino commented Oct 11, 2024

Proposed Changes

  • Refactored the logic to handle URL redirection after saving a UrlContentMap.
  • Added methods to extract and determine the target URL for redirection, ensuring the correct URL is used when publishing content.

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Additional Info

This fix addresses the issue where, after saving or publishing a UrlContentMap, the system incorrectly redirects to the content type’s detail page instead of the expected URL. The changes ensure that the correct URL is detected and used, preventing unwanted redirection after the save or publish action.

Screenshots

Before:

issue-29896-uve-fix-urlcontentmaps-redirect.mov

After:

fix-issue-29896-uve-fix-urlcontentmaps-redirect.mov

This PR fixes: #29896

@valentinogiardino valentinogiardino marked this pull request as ready for review October 15, 2024 14:25
@valentinogiardino valentinogiardino added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 03c82c1 Oct 15, 2024
21 checks passed
@valentinogiardino valentinogiardino deleted the issue-29896-uve-fix-urlcontentmaps-redirect branch October 15, 2024 17:26
spbolton pushed a commit that referenced this pull request Nov 11, 2024
…lish #29896 (#30334)

### Proposed Changes
* Refactored the logic to handle URL redirection after saving a
UrlContentMap.
* Added methods to extract and determine the target URL for redirection,
ensuring the correct URL is used when publishing content.

### Checklist
- [x] Tests
- [x] Translations
- [x] Security Implications Contemplated (add notes if applicable)

### Additional Info
This fix addresses the issue where, after saving or publishing a
UrlContentMap, the system incorrectly redirects to the content type’s
detail page instead of the expected URL. The changes ensure that the
correct URL is detected and used, preventing unwanted redirection after
the save or publish action.

### Screenshots
#### Before:


https://github.com/user-attachments/assets/1b4f74fa-f0b7-46f4-b389-a1bc63f52f7b

#### After:


https://github.com/user-attachments/assets/84ea8aa1-a434-4c17-a4b3-b4f391a58d14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UVE: Incorrect Redirection After Saving or Publishing UrlContentMaps
4 participants