Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): Sonar Quality Gate failure due to potential division by zero (#30337) #30338

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix(backend): Sonar Quality Gate failure due to potential division by zero (#30337) #30338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dotCMS/src/main/java/com/dotcms/jobs/business/processor/impl/LargeFileReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ public void process(Job job) {
*/
private void doReadLargeFile(DotTempFile dotTempFile, int nLines, int maxLines ,final Job job) {
final Long totalCount = countLines(dotTempFile);
if (totalCount == null) {
if (totalCount == null || totalCount == 0 ) {
Logger.error(this.getClass(), "No lines in the file or unable to count lines: " + dotTempFile.file.getName());
return;
}
Logger.info(this.getClass(), "Total lines in the file: " + totalCount);
Expand Down