Fix (Core) Fixed calculateBackoffTime in JobQueueManagerAPIImpl #30350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced the calculateBackoffTime method to manage exponential backoff in job processing. Added corresponding unit tests and implemented a reset mechanism for the emptyQueueCount to improve reliability.
dcolina
approved these changes
Oct 15, 2024
valentinogiardino
approved these changes
Oct 15, 2024
|
jgambarios
deleted the
issue-30348-Job-Queue-Negative-Timeout-Value-Causes-Error-in-logs
branch
spbolton
pushed a commit
that referenced
this pull request
Nov 11, 2024
This pull request introduces enhancements to the job queue management system to handle empty queue scenarios more effectively. The key changes include adding constants to cap and reset the empty queue count, refactoring the backoff time calculation, and adding tests for the new functionality. Enhancements to job queue management: * [`dotCMS/src/main/java/com/dotcms/jobs/business/api/JobQueueManagerAPIImpl.java`](diffhunk://#diff-c092f8af2f800c0ca84f2c2f4aed0af60d0ed488e20fa32992967e154064f561R117-R121): Introduced `MAX_EMPTY_QUEUE_COUNT` and `EMPTY_QUEUE_RESET_THRESHOLD` constants to cap and reset the empty queue count. * [`dotCMS/src/main/java/com/dotcms/jobs/business/api/JobQueueManagerAPIImpl.java`](diffhunk://#diff-c092f8af2f800c0ca84f2c2f4aed0af60d0ed488e20fa32992967e154064f561L476-R485): Refactored `processJobs` method to use `calculateBackoffTime` and `incrementAndResetEmptyQueueCount` methods for better handling of empty queue scenarios. * [`dotCMS/src/main/java/com/dotcms/jobs/business/api/JobQueueManagerAPIImpl.java`](diffhunk://#diff-c092f8af2f800c0ca84f2c2f4aed0af60d0ed488e20fa32992967e154064f561R975-R1005): Added `calculateBackoffTime` and `incrementAndResetEmptyQueueCount` methods to encapsulate the logic for calculating backoff time and resetting the empty queue count. Testing improvements: * [`dotcms-integration/src/test/java/com/dotcms/jobs/business/api/JobQueueManagerAPITest.java`](diffhunk://#diff-93563af6a56c7a961561131bb9cb95c6ea24b9ba8508e3a98dc49d036ff78859R1293-R1312): Added `test_calculateBackoffTime` method to verify the correctness of the `calculateBackoffTime` method under various scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the job queue management system to handle empty queue scenarios more effectively. The key changes include adding constants to cap and reset the empty queue count, refactoring the backoff time calculation, and adding tests for the new functionality.
Enhancements to job queue management:
dotCMS/src/main/java/com/dotcms/jobs/business/api/JobQueueManagerAPIImpl.java: IntroducedMAX_EMPTY_QUEUE_COUNTandEMPTY_QUEUE_RESET_THRESHOLDconstants to cap and reset the empty queue count.dotCMS/src/main/java/com/dotcms/jobs/business/api/JobQueueManagerAPIImpl.java: RefactoredprocessJobsmethod to usecalculateBackoffTimeandincrementAndResetEmptyQueueCountmethods for better handling of empty queue scenarios.dotCMS/src/main/java/com/dotcms/jobs/business/api/JobQueueManagerAPIImpl.java: AddedcalculateBackoffTimeandincrementAndResetEmptyQueueCountmethods to encapsulate the logic for calculating backoff time and resetting the empty queue count.Testing improvements:
dotcms-integration/src/test/java/com/dotcms/jobs/business/api/JobQueueManagerAPITest.java: Addedtest_calculateBackoffTimemethod to verify the correctness of thecalculateBackoffTimemethod under various scenarios.This PR fixes: #30348