#30361: allowing stream chat to dotAI #30377
Merged
+185
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victoralfaro-dotcms
force-pushed
the
30361-enhance-dotai-stream-chat
branch
2 times, most recently
from
df6fee9 to
b98ee1a
Compare
victoralfaro-dotcms
force-pushed
the
30361-enhance-dotai-stream-chat
branch
from
b98ee1a to
cf4a7c0
Compare
|
dsilvam
approved these changes
Oct 24, 2024
oidacra
approved these changes
Oct 24, 2024
jdotcms
reviewed
Oct 25, 2024
| final OutputStream incoming) { | ||
| final JSONObjectAIRequest jsonRequest = AIClient.useRequestOrThrow(request); | ||
| final boolean isStream = AIClientStrategy.isStream(jsonRequest); | ||
| final OutputStream output = Optional.ofNullable(incoming).orElseGet(ByteArrayOutputStream::new); |
spbolton
pushed a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a different approach, besides evaluating actual content, we know evaluate http status code in the case of stream mode.
This PR fixes: #30361