chore(edit-content): Use new Angular Syntax in DotNavigationComponent #30403
+265
−233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oidacra
approved these changes
Oct 18, 2024
hmoreras
approved these changes
Oct 18, 2024
|
nicobytes
deleted the
30401-use-new-angular-syntax-in-dotnavigationcomponent
branch
spbolton
pushed a commit
that referenced
this pull request
Nov 11, 2024
…#30403) ### Parent Issue #30401 ### Proposed Changes This pull request includes some changes to the `dot-navigation` components in the `dotcms-ui` application. The primary focus is on refactoring the code to use Angular's new reactive primitives and simplifying the template syntax. ### Template Refactoring: * [`core-web/apps/dotcms-ui/src/app/view/components/dot-navigation/components/dot-nav-icon/dot-nav-icon.component.html`](diffhunk://#diff-93a54f28d1e0bee7ef4548b64f4803d76086c903bcc0da2dafec62761c72c9fdL1-R5): Replaced `*ngIf` and `ng-template` with Angular's new `@if` and `@else` syntax. * [`core-web/apps/dotcms-ui/src/app/view/components/dot-navigation/components/dot-sub-nav/dot-sub-nav.component.html`](diffhunk://#diff-1f36b07f7cdfbecc666246d6847285e225e96a1ee4802cd8c11c6bb149e484a0L2-R3): Updated `*ngFor` to use the new `@for` syntax with tracking. [[1]](diffhunk://#diff-1f36b07f7cdfbecc666246d6847285e225e96a1ee4802cd8c11c6bb149e484a0L2-R3) [[2]](diffhunk://#diff-1f36b07f7cdfbecc666246d6847285e225e96a1ee4802cd8c11c6bb149e484a0R13) * [`core-web/apps/dotcms-ui/src/app/view/components/dot-navigation/dot-navigation.component.html`](diffhunk://#diff-536660425506325914cc437d2a9733660d2ea944540b0c354e4599435ad85e06L1-R12): Replaced `*ngFor` and async pipe with `@for` and reactive signals. ### Component Refactoring: * [`core-web/apps/dotcms-ui/src/app/view/components/dot-navigation/dot-navigation.component.ts`](diffhunk://#diff-6e9db9ff07d7bd661a702691aa91170567a42d0a9786902f91cdd899b7da1b51L3-R4): Replaced constructor dependency injection with the `inject` function and used `toSignal` to convert observables to signals. [[1]](diffhunk://#diff-6e9db9ff07d7bd661a702691aa91170567a42d0a9786902f91cdd899b7da1b51L3-R4) [[2]](diffhunk://#diff-6e9db9ff07d7bd661a702691aa91170567a42d0a9786902f91cdd899b7da1b51L16-R32) * [`core-web/apps/dotcms-ui/src/app/view/components/dot-navigation/dot-navigation.component.ts`](diffhunk://#diff-6e9db9ff07d7bd661a702691aa91170567a42d0a9786902f91cdd899b7da1b51L43-R47): Updated method calls to use private fields for services. [[1]](diffhunk://#diff-6e9db9ff07d7bd661a702691aa91170567a42d0a9786902f91cdd899b7da1b51L43-R47) [[2]](diffhunk://#diff-6e9db9ff07d7bd661a702691aa91170567a42d0a9786902f91cdd899b7da1b51L56-R62) [[3]](diffhunk://#diff-6e9db9ff07d7bd661a702691aa91170567a42d0a9786902f91cdd899b7da1b51L70-R74) ### Checklist - [x] Tests - [x] Translations - [x] Security Implications Contemplated (add notes if applicable) ### Screenshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent Issue
#30401
Proposed Changes
This pull request includes some changes to the
dot-navigationcomponents in thedotcms-uiapplication. The primary focus is on refactoring the code to use Angular's new reactive primitives and simplifying the template syntax.Template Refactoring:
core-web/apps/dotcms-ui/src/app/view/components/dot-navigation/components/dot-nav-icon/dot-nav-icon.component.html: Replaced*ngIfandng-templatewith Angular's new@ifand@elsesyntax.core-web/apps/dotcms-ui/src/app/view/components/dot-navigation/components/dot-sub-nav/dot-sub-nav.component.html: Updated*ngForto use the new@forsyntax with tracking. [1] [2]core-web/apps/dotcms-ui/src/app/view/components/dot-navigation/dot-navigation.component.html: Replaced*ngForand async pipe with@forand reactive signals.Component Refactoring:
core-web/apps/dotcms-ui/src/app/view/components/dot-navigation/dot-navigation.component.ts: Replaced constructor dependency injection with theinjectfunction and usedtoSignalto convert observables to signals. [1] [2]core-web/apps/dotcms-ui/src/app/view/components/dot-navigation/dot-navigation.component.ts: Updated method calls to use private fields for services. [1] [2] [3]Checklist
Screenshots
This PR fixes: #30401