issue-29621: Excluding Hidden content types from the Widgets displayed #30517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spbolton
changed the title
spbolton
changed the title
Neehakethi
force-pushed
the
issue-29621-Hide-Forms-from-Palette
branch
from
8477a3a to
0a85a98
Compare
|
oidacra
reviewed
Oct 31, 2024
.../portlet/src/lib/edit-ema-editor/components/edit-ema-palette/store/edit-ema-palette.store.ts
Outdated
Show resolved
Hide resolved
fmontes
approved these changes
Nov 29, 2024
.../portlet/src/lib/edit-ema-editor/components/edit-ema-palette/store/edit-ema-palette.store.ts
Outdated
Show resolved
Hide resolved
|
The code LGTM but we need a unit test to merge it |
rjvelazco
reviewed
Dec 9, 2024
hmoreras
approved these changes
Dec 26, 2024
zJaaal
approved these changes
Dec 26, 2024
KevinDavilaDotCMS
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the
DotPaletteStoreand related test files to enhance the handling of content types and widgets, including the filtering of hidden content types. The most important changes include adding theDotPropertiesServicefor configuration management and refactoring the content type loading logic.Enhancements to
DotPaletteStore:DotPropertiesServiceto manage configuration settings and retrieve hidden content types (CONTENT_PALETTE_HIDDEN_CONTENT_TYPES). ([[1]](https://github.com/dotCMS/core/pull/30517/files#diff-8262303c46e34e159efdc68dec99a47ddf453302794be94483b1abee94c13556R9),[[2]](https://github.com/dotCMS/core/pull/30517/files#diff-5e9e57d14e6a9185a0988e2062be4028f862924c1b068ac9eddab73da058e94fR13-R20),[[3]](https://github.com/dotCMS/core/pull/30517/files#diff-5e9e57d14e6a9185a0988e2062be4028f862924c1b068ac9eddab73da058e94fL166-R169))getContenttypesDatamethod to useforkJoinwith multiple observables, including hidden content types, and improved the filtering logic to exclude hidden content types. ([core-web/apps/dotcms-ui/src/app/portlets/dot-edit-page/components/dot-palette/store/dot-palette.store.tsL252-L282](https://github.com/dotCMS/core/pull/30517/files#diff-5e9e57d14e6a9185a0988e2062be4028f862924c1b068ac9eddab73da058e94fL252-L282))Updates to tests:
DotPropertiesServiceand verify the filtering of hidden content types indot-palette.store.spec.tsandedit-ema-palette.store.spec.ts. ([[1]](https://github.com/dotCMS/core/pull/30517/files#diff-8262303c46e34e159efdc68dec99a47ddf453302794be94483b1abee94c13556R114-R136),[[2]](https://github.com/dotCMS/core/pull/30517/files#diff-8262303c46e34e159efdc68dec99a47ddf453302794be94483b1abee94c13556R147),[[3]](https://github.com/dotCMS/core/pull/30517/files#diff-8262303c46e34e159efdc68dec99a47ddf453302794be94483b1abee94c13556L185-R233),[[4]](https://github.com/dotCMS/core/pull/30517/files#diff-1440c725f71c6ba67d7a4847e983e63b1e7a3a4fe17042aafe9553a89ad19f22L46-R82),[[5]](https://github.com/dotCMS/core/pull/30517/files#diff-1440c725f71c6ba67d7a4847e983e63b1e7a3a4fe17042aafe9553a89ad19f22R119-R131),[[6]](https://github.com/dotCMS/core/pull/30517/files#diff-1440c725f71c6ba67d7a4847e983e63b1e7a3a4fe17042aafe9553a89ad19f22R141-R160))Refactoring:
[[1]](https://github.com/dotCMS/core/pull/30517/files#diff-8262303c46e34e159efdc68dec99a47ddf453302794be94483b1abee94c13556R114-R136),[[2]](https://github.com/dotCMS/core/pull/30517/files#diff-8262303c46e34e159efdc68dec99a47ddf453302794be94483b1abee94c13556L185-R233),[[3]](https://github.com/dotCMS/core/pull/30517/files#diff-e60190c318aa61ddbc495b1c20398bb42e7baa8429b8241aa6964267f3ddd445L235-L259))These changes improve the overall functionality and maintainability of the
DotPaletteStoreby incorporating configuration management and enhancing the content type filtering logic.Video
issue-29621-Hide-Forms-from-Palette-1.mov
This PR fixes: #29621