chore(Telemetry) #30079 : Move telemetry plugin into core - Part 1 #30520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddyDOTCMS
approved these changes
Oct 30, 2024
|
jcastro-dotcms
deleted the
issue-30079-Move-telemetry-plugin-into-core-part-1
branch
dsolistorres
pushed a commit
that referenced
this pull request
Nov 5, 2024
…30520) ### Proposed Changes * Migrates all the code from the `Telemetry` plug-in into our `core` project. * This is the first part of the process, so it just takes the code "as is" from the plugin, and places it inside the `core` project. It only includes a few adjustments on some Javadoc, code formatting, and the addition of the `toString()` method in a few classes. * These changes can safely co-exist with the current `Telemetry` plugin. * In order to have a more effective Code Review process, the goal is to have two pull requests: * The first one with the existing code from the plugin -- this one. * The second one with the code changes in `core` that effectively add the REST Endpoint, Web Interceptor, and Quartz Job which are currently being added via the `Activator` class.
|
This is the previous PR that had to be closed because of conflicts: #30476 I'm just posting it here for future references to Code Review requests. |
spbolton
pushed a commit
that referenced
this pull request
Nov 11, 2024
…30520) ### Proposed Changes * Migrates all the code from the `Telemetry` plug-in into our `core` project. * This is the first part of the process, so it just takes the code "as is" from the plugin, and places it inside the `core` project. It only includes a few adjustments on some Javadoc, code formatting, and the addition of the `toString()` method in a few classes. * These changes can safely co-exist with the current `Telemetry` plugin. * In order to have a more effective Code Review process, the goal is to have two pull requests: * The first one with the existing code from the plugin -- this one. * The second one with the code changes in `core` that effectively add the REST Endpoint, Web Interceptor, and Quartz Job which are currently being added via the `Activator` class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Telemetryplug-in into ourcoreproject.coreproject. It only includes a few adjustments on some Javadoc, code formatting, and the addition of thetoString()method in a few classes.Telemetryplugin.corethat effectively add the REST Endpoint, Web Interceptor, and Quartz Job which are currently being added via theActivatorclass.This PR fixes: #30079