SDK: Unable to Edit Unpublished Page in Angular Example #30542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjvelazco
requested review from
fmontes,
zJaaal,
oidacra,
nicobytes,
hmoreras and
valentinogiardino
and removed request for
fmontes
…age-in-angular-example-feedback
…lar-example-feedback' of https://github.com/dotCMS/core into issue-30440-sdk-unable-to-edit-unpublished-page-in-angular-example-feedback
zJaaal
reviewed
Oct 31, 2024
…age-in-angular-example-feedback
zJaaal
approved these changes
Oct 31, 2024
…lar-example-feedback' of https://github.com/dotCMS/core into issue-30440-sdk-unable-to-edit-unpublished-page-in-angular-example-feedback
valentinogiardino
approved these changes
Nov 1, 2024
oidacra
approved these changes
Nov 1, 2024
rjvelazco
deleted the
issue-30440-sdk-unable-to-edit-unpublished-page-in-angular-example-feedback
branch
dsolistorres
pushed a commit
that referenced
this pull request
Nov 5, 2024
This pull request includes several updates to the `DotCMSPagesComponent` in the Angular example application. The changes primarily focus on integrating editor-related functionality and improving code formatting. ### Editor Integration: * Added `DOTCMS_CLIENT_TOKEN` import and injected it into the `DotCMSPagesComponent` to enable editor-related functionalities. [[1]](diffhunk://#diff-db19dde961c6af3dbddd86db7544e4ea4ff42baae9095cee4e3017c1d4dcb395L20-R26) [[2]](diffhunk://#diff-db19dde961c6af3dbddd86db7544e4ea4ff42baae9095cee4e3017c1d4dcb395R66-R85) * Implemented a new method `#listenToEditorChanges` to handle editor changes and update the component state accordingly. ### Code Formatting: * Reformatted the import statements for better readability and maintainability. * Adjusted the method signature formatting for `#setPageContent` to be consistent with the rest of the codebase. ### Video https://github.com/user-attachments/assets/7ee487ce-412f-4504-8ff1-f92dac86beee --------- Co-authored-by: Jalinson Diaz <[email protected]>
spbolton
pushed a commit
that referenced
this pull request
Nov 11, 2024
This pull request includes several updates to the `DotCMSPagesComponent` in the Angular example application. The changes primarily focus on integrating editor-related functionality and improving code formatting. ### Editor Integration: * Added `DOTCMS_CLIENT_TOKEN` import and injected it into the `DotCMSPagesComponent` to enable editor-related functionalities. [[1]](diffhunk://#diff-db19dde961c6af3dbddd86db7544e4ea4ff42baae9095cee4e3017c1d4dcb395L20-R26) [[2]](diffhunk://#diff-db19dde961c6af3dbddd86db7544e4ea4ff42baae9095cee4e3017c1d4dcb395R66-R85) * Implemented a new method `#listenToEditorChanges` to handle editor changes and update the component state accordingly. ### Code Formatting: * Reformatted the import statements for better readability and maintainability. * Adjusted the method signature formatting for `#setPageContent` to be consistent with the rest of the codebase. ### Video https://github.com/user-attachments/assets/7ee487ce-412f-4504-8ff1-f92dac86beee --------- Co-authored-by: Jalinson Diaz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
DotCMSPagesComponentin the Angular example application. The changes primarily focus on integrating editor-related functionality and improving code formatting.Editor Integration:
DOTCMS_CLIENT_TOKENimport and injected it into theDotCMSPagesComponentto enable editor-related functionalities. [1] [2]#listenToEditorChangesto handle editor changes and update the component state accordingly.Code Formatting:
#setPageContentto be consistent with the rest of the codebase.Video
issue-30440-sdk-unable-to-edit-unpublished-page-in-angular-example-feedback.mov
This PR fixes: #30440