fix(examples): Hide edit button outside editor #30657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zJaaal
requested review from
fmontes,
oidacra,
hmoreras,
rjvelazco,
valentinogiardino and
KevinDavilaDotCMS
rjvelazco
approved these changes
Nov 14, 2024
hmoreras
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
examples/nextjs/src/components/shared/contentlets.jsfile to improve the functionality and performance of theContentletscomponent. The most important changes include replacingReactwithuseMemo, adding a new import forisInsideEditor, and conditionally rendering the edit button based on whether the contentlet is inside the editor.Improvements to functionality:
examples/nextjs/src/components/shared/contentlets.js: Replaced theReactimport withuseMemoto memoize theisInsideEditorfunction.examples/nextjs/src/components/shared/contentlets.js: Added a new import forisInsideEditorfrom@dotcms/clientto check if the contentlet is inside the editor.examples/nextjs/src/components/shared/contentlets.js: UseduseMemoto create a memoized valueinsideEditorfor determining if the contentlet is inside the editor.examples/nextjs/src/components/shared/contentlets.js: Conditionally rendered the edit button based on theinsideEditorvalue to improve user experience.This PR fixes: #30218