-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle 2 workflows for 1 contenttype #30658
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oidacra
commented
Nov 14, 2024
core-web/libs/dotcms-models/src/lib/dot-workflow-action.model.ts
Outdated
Show resolved
Hide resolved
oidacra
force-pushed
the
30596-multiple-workflow-contentype
branch
from
November 14, 2024 18:29
d764ead
to
18015ae
Compare
oidacra
force-pushed
the
30596-multiple-workflow-contentype
branch
2 times, most recently
from
November 18, 2024 18:29
c71b82f
to
92c41cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 21 out of 36 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- core-web/libs/data-access/project.json: Language not supported
- core-web/libs/dotcms-scss/angular/dotcms-theme/components/messages/_message.scss: Language not supported
- core-web/libs/edit-content/src/lib/components/dot-edit-content-form/dot-edit-content-form.component.html: Language not supported
- core-web/libs/edit-content/src/lib/components/dot-edit-content-sidebar/components/dot-edit-content-sidebar-information/dot-edit-content-sidebar-information.component.html: Language not supported
- core-web/libs/edit-content/src/lib/components/dot-edit-content-sidebar/components/dot-edit-content-sidebar-workflow/dot-edit-content-sidebar-workflow.component.html: Language not supported
- core-web/libs/edit-content/src/lib/components/dot-edit-content-sidebar/components/dot-edit-content-sidebar-workflow/dot-edit-content-sidebar-workflow.component.scss: Language not supported
- core-web/libs/edit-content/src/lib/components/dot-edit-content-sidebar/dot-edit-content-sidebar.component.html: Language not supported
- core-web/libs/edit-content/src/lib/feature/edit-content/edit-content.layout.component.html: Language not supported
- core-web/libs/edit-content/src/lib/feature/edit-content/edit-content.layout.component.scss: Language not supported
- core-web/libs/data-access/src/lib/dot-workflows-actions/dot-workflows-actions.service.spec.ts: Evaluated as low risk
- core-web/libs/data-access/src/lib/dot-workflows-actions/dot-workflows-actions.service.ts: Evaluated as low risk
- core-web/libs/dotcms-models/src/lib/dot-workflow-action.model.ts: Evaluated as low risk
- core-web/libs/edit-content/src/lib/components/dot-edit-content-form/dot-edit-content-form.component.ts: Evaluated as low risk
- core-web/libs/edit-content/src/lib/components/dot-edit-content-sidebar/components/dot-edit-content-sidebar-information/dot-edit-content-sidebar-information.component.spec.ts: Evaluated as low risk
- core-web/libs/edit-content/src/lib/components/dot-edit-content-sidebar/dot-edit-content-sidebar.component.ts: Evaluated as low risk
oidacra
force-pushed
the
30596-multiple-workflow-contentype
branch
from
November 19, 2024 02:25
9c0821e
to
e5c71bf
Compare
hmoreras
reviewed
Nov 19, 2024
...omponents/dot-edit-content-sidebar-workflow/dot-edit-content-sidebar-workflow.component.html
Outdated
Show resolved
Hide resolved
hmoreras
reviewed
Nov 19, 2024
...omponents/dot-edit-content-sidebar-workflow/dot-edit-content-sidebar-workflow.component.html
Outdated
Show resolved
Hide resolved
oidacra
force-pushed
the
30596-multiple-workflow-contentype
branch
from
November 19, 2024 17:04
4a7c8ad
to
cdb8b0f
Compare
oidacra
requested review from
hmoreras,
zJaaal,
KevinDavilaDotCMS and
valentinogiardino
November 19, 2024 17:05
hmoreras
approved these changes
Nov 19, 2024
nicobytes
previously requested changes
Nov 20, 2024
core-web/libs/dotcms-scss/angular/dotcms-theme/components/messages/_message.scss
Show resolved
Hide resolved
...nts/dot-edit-content-sidebar-information/dot-edit-content-sidebar-information.component.html
Outdated
Show resolved
Hide resolved
...nts/dot-edit-content-sidebar-information/dot-edit-content-sidebar-information.component.html
Show resolved
Hide resolved
...omponents/dot-edit-content-sidebar-workflow/dot-edit-content-sidebar-workflow.component.html
Outdated
Show resolved
Hide resolved
...omponents/dot-edit-content-sidebar-workflow/dot-edit-content-sidebar-workflow.component.html
Show resolved
Hide resolved
.../components/dot-edit-content-sidebar-workflow/dot-edit-content-sidebar-workflow.component.ts
Outdated
Show resolved
Hide resolved
core-web/libs/edit-content/src/lib/feature/edit-content/store/edit-content.store.ts
Show resolved
Hide resolved
zJaaal
previously requested changes
Nov 21, 2024
...omponents/dot-edit-content-sidebar-workflow/dot-edit-content-sidebar-workflow.component.scss
Outdated
Show resolved
Hide resolved
core-web/libs/edit-content/src/lib/feature/edit-content/store/features/content.feature.ts
Outdated
Show resolved
Hide resolved
core-web/libs/edit-content/src/lib/feature/edit-content/store/features/content.feature.ts
Show resolved
Hide resolved
core-web/libs/edit-content/src/lib/feature/edit-content/store/features/workflow.feature.ts
Outdated
Show resolved
Hide resolved
fmontes
previously requested changes
Nov 21, 2024
core-web/libs/dotcms-scss/angular/dotcms-theme/components/messages/_message.scss
Show resolved
Hide resolved
...nts/dot-edit-content-sidebar-information/dot-edit-content-sidebar-information.component.html
Outdated
Show resolved
Hide resolved
...nts/dot-edit-content-sidebar-information/dot-edit-content-sidebar-information.component.html
Outdated
Show resolved
Hide resolved
...omponents/dot-edit-content-sidebar-workflow/dot-edit-content-sidebar-workflow.component.html
Show resolved
Hide resolved
core-web/libs/edit-content/src/lib/feature/edit-content/store/edit-content.store.ts
Show resolved
Hide resolved
core-web/libs/edit-content/src/lib/feature/edit-content/store/features/content.feature.ts
Show resolved
Hide resolved
oidacra
dismissed stale reviews from fmontes, zJaaal, and nicobytes
November 21, 2024 22:02
fixed comments
oidacra
force-pushed
the
30596-multiple-workflow-contentype
branch
from
November 21, 2024 22:03
2734590
to
bc57c7e
Compare
Quality Gate passedIssues Measures |
nicobytes
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the handling of workflow actions, update the styling of messages, and enhance the edit content form component. The most important changes include modifications to the workflow actions service, updates to the message component styles, and adjustments to the edit content form component.
Workflow Actions Service Enhancements:
DotCMSWorkflowActions
to include the first step of the workflow (core-web/libs/data-access/src/lib/dot-workflows-actions/dot-workflows-actions.service.ts
).getDefaultActions
method to returnDotCMSWorkflowActions[]
instead ofDotCMSWorkflowAction[]
(core-web/libs/data-access/src/lib/dot-workflows-actions/dot-workflows-actions.service.ts
).getWorkFlowActions
to retrieve workflow actions by content type name (core-web/libs/data-access/src/lib/dot-workflows-actions/dot-workflows-actions.service.ts
).MOCK_SINGLE_WORKFLOW_ACTIONS
and verify the new methodgetWorkFlowActions
(core-web/libs/data-access/src/lib/dot-workflows-actions/dot-workflows-actions.service.spec.ts
). [1] [2] [3]Message Component Styling Updates:
core-web/libs/dotcms-scss/angular/dotcms-theme/components/messages/_message.scss
).core-web/libs/dotcms-scss/angular/dotcms-theme/components/messages/_message.scss
).core-web/libs/dotcms-scss/angular/dotcms-theme/components/messages/_message.scss
).Edit Content Form Component Enhancements:
core-web/libs/edit-content/src/lib/components/dot-edit-content-form/dot-edit-content-form.component.html
). [1] [2] [3]core-web/libs/edit-content/src/lib/components/dot-edit-content-form/dot-edit-content-form.component.spec.ts
). [1] [2] [3] [4] [5] [6]Additional Changes:
DotCMSWorkflowAction
interface to support various actionlets (core-web/libs/dotcms-models/src/lib/dot-workflow-action.model.ts
).firstStep
property to theDotCMSWorkflowStatus
interface (core-web/libs/dotcms-models/src/lib/dot-workflow.model.ts
).project.json
file to include a new linting tag (core-web/libs/data-access/project.json
).Checklist
Additional Info
** any additional useful context or info **
Screenshots
2 Workflows
CleanShot.2024-11-15.at.11.12.01.mp4
1 Workflow
CleanShot.2024-11-15.at.11.14.35.mp4
This PR fixes: #30596