chore(Preview Mode): Add SEO results to device dropdown for traditional pages #31035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjvelazco
reviewed
Jan 3, 2025
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/toolbar/withUVEToolbar.ts
Show resolved
Hide resolved
…vice-dropdown-for-traditional-pages
zJaaal
requested changes
Jan 6, 2025
...ts/dot-uve-toolbar/components/dot-uve-device-selector/dot-uve-device-selector.component.html
Outdated
Show resolved
Hide resolved
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/toolbar/withUVEToolbar.ts
Show resolved
Hide resolved
…vice-dropdown-for-traditional-pages
…vice-dropdown-for-traditional-pages
rjvelazco
requested review from
fmontes,
valentinogiardino,
oidacra,
nicobytes,
hmoreras and
rjvelazco
...-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/dot-uve-toolbar.component.ts
Outdated
Show resolved
Hide resolved
...ma/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/dot-uve-toolbar.component.html
Show resolved
Hide resolved
...ents/dot-uve-toolbar/components/dot-uve-device-selector/dot-uve-device-selector.component.ts
Show resolved
Hide resolved
zJaaal
changed the title
rjvelazco
approved these changes
Jan 6, 2025
nicobytes
reviewed
Jan 6, 2025
...tor/components/dot-uve-toolbar/components/dot-ema-bookmarks/dot-ema-bookmarks.component.html
Outdated
Show resolved
Hide resolved
oidacra
reviewed
Jan 6, 2025
...tor/components/dot-uve-toolbar/components/dot-ema-bookmarks/dot-ema-bookmarks.component.html
Outdated
Show resolved
Hide resolved
nicobytes
reviewed
Jan 6, 2025
...ts/dot-uve-toolbar/components/dot-uve-device-selector/dot-uve-device-selector.component.html
Outdated
Show resolved
Hide resolved
oidacra
reviewed
Jan 6, 2025
...tor/components/dot-uve-toolbar/components/dot-ema-bookmarks/dot-ema-bookmarks.component.html
Outdated
Show resolved
Hide resolved
oidacra
reviewed
Jan 6, 2025
...portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/dot-uve-toolbar.component.spec.ts
Outdated
Show resolved
Hide resolved
nicobytes
reviewed
Jan 6, 2025
...-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/dot-uve-toolbar.component.ts
Outdated
Show resolved
Hide resolved
nicobytes
reviewed
Jan 6, 2025
.../portlets/edit-ema/ui/src/lib/dot-device-selector-seo/dot-device-selector-seo.component.html
Outdated
Show resolved
Hide resolved
zJaaal
approved these changes
Jan 7, 2025
...ma/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/dot-uve-toolbar.component.html
Show resolved
Hide resolved
…vice-dropdown-for-traditional-pages
nicobytes
reviewed
Jan 7, 2025
...tor/components/dot-uve-toolbar/components/dot-ema-bookmarks/dot-ema-bookmarks.component.html
Outdated
Show resolved
Hide resolved
nicobytes
approved these changes
Jan 7, 2025
oidacra
approved these changes
Jan 7, 2025
rjvelazco
changed the title
rjvelazco
deleted the
30921-ftm-preview-mode-add-seo-results-to-device-dropdown-for-traditional-pages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
core-web/libsdirectory, focusing on refactoring enums, adding tooltips, and updating test cases. The most important changes include refactoring SEO enums, adding tooltips to bookmarks, and updating the device selector component and its tests.Refactoring enums and constants:
core-web/libs/dotcms-models/src/lib/meta-tags-model.ts: RefactoredSEO_MEDIA_TYPESto separateSOCIAL_MEDIA_TYPESandSEARCH_ENGINE_TYPESenums and updated references accordingly. [1] [2]Adding tooltips:
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/components/dot-ema-bookmarks/dot-ema-bookmarks.component.html: Added tooltips to the bookmark button.core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/components/dot-ema-bookmarks/dot-ema-bookmarks.component.ts: ImportedTooltipModuleto support tooltips. [1] [2]Updating device selector component and tests:
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/components/dot-uve-device-selector/dot-uve-device-selector.component.html: Updated the device selector menu with new styles and templates.core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/components/dot-uve-device-selector/dot-uve-device-selector.component.scss: Adjusted styles for the device selector menu. [1] [2]core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/components/dot-uve-device-selector/dot-uve-device-selector.component.spec.ts: Updated test cases to reflect changes in the device selector component. [1] [2] [3] [4]Video
feature-30921-ftm-preview-mode-add-seo-results-to-device-dropdown-for-traditional-pages.mov
This PR fixes: #30921