fix(edit-content) fix minors bugs Edit Content #31065
Merged
+93
−49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various changes to the
core-web
library, focusing on improving the sidebar component, updating the contentlet status pipe, and enhancing the workflow feature. Below are the most important changes:Sidebar Component Updates:
dot-edit-content-sidebar-information.component.html
to simplify tooltip logic by directly assigningcontentlet
properties topTooltip
attributes. [1] [2] [3]dot-edit-content-sidebar.component.html
..temporal-content
class indot-edit-content-sidebar.component.scss
to style the placeholder content.Contentlet Status Pipe Enhancements:
contentlet-status.pipe.ts
to refine status determination logic, including handling for unchanged live content and draft content.contentlet-status.pipe.spec.ts
to reflect changes in status logic and added a test case for undefined contentlets. [1] [2]Workflow Feature Enhancements:
DotWorkflowService
inworkflow.feature.ts
and updated the workflow feature to include workflow status fetching. [1] [2] [3] [4] [5]workflow.feature.spec.ts
to mockDotWorkflowService
and verify the new workflow status logic. [1] [2] [3] [4] [5] [6] [7] [8]Miscellaneous:
withDebug
feature toedit-content.store.ts
for enhanced debugging capabilities. [1] [2]content.feature.ts
by directly using the provided step.Proposed Changes
Checklist
Additional Info
** any additional useful context or info **
Screenshots
This PR fixes: #30879