Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edit-content) fix minors bugs Edit Content #31065

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Conversation

oidacra
Copy link
Member

@oidacra oidacra commented Jan 6, 2025

This pull request includes various changes to the core-web library, focusing on improving the sidebar component, updating the contentlet status pipe, and enhancing the workflow feature. Below are the most important changes:

Sidebar Component Updates:

  • Updated dot-edit-content-sidebar-information.component.html to simplify tooltip logic by directly assigning contentlet properties to pTooltip attributes. [1] [2] [3]
  • Added new tabs for "History" and "Settings" with placeholder content in dot-edit-content-sidebar.component.html.
  • Added .temporal-content class in dot-edit-content-sidebar.component.scss to style the placeholder content.

Contentlet Status Pipe Enhancements:

  • Modified contentlet-status.pipe.ts to refine status determination logic, including handling for unchanged live content and draft content.
  • Updated contentlet-status.pipe.spec.ts to reflect changes in status logic and added a test case for undefined contentlets. [1] [2]

Workflow Feature Enhancements:

  • Injected DotWorkflowService in workflow.feature.ts and updated the workflow feature to include workflow status fetching. [1] [2] [3] [4] [5]
  • Updated workflow.feature.spec.ts to mock DotWorkflowService and verify the new workflow status logic. [1] [2] [3] [4] [5] [6] [7] [8]

Miscellaneous:

  • Added withDebug feature to edit-content.store.ts for enhanced debugging capabilities. [1] [2]
  • Simplified content state handling in content.feature.ts by directly using the provided step.

Proposed Changes

  • fix the correct name of WF after the trigger action
  • fix the tooltip to truncated name
  • fix status pipe logic

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Additional Info

** any additional useful context or info **

Screenshots

Original Updated
** original screenshot ** ** updated screenshot **

This PR fixes: #30879

…ooltip to truncated name, fix status pipe logic
@nicobytes nicobytes requested a review from Copilot January 6, 2025 19:27

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • core-web/libs/edit-content/src/lib/components/dot-edit-content-sidebar/components/dot-edit-content-sidebar-information/dot-edit-content-sidebar-information.component.html: Language not supported
  • core-web/libs/edit-content/src/lib/components/dot-edit-content-sidebar/dot-edit-content-sidebar.component.html: Language not supported
  • core-web/libs/edit-content/src/lib/components/dot-edit-content-sidebar/dot-edit-content-sidebar.component.scss: Language not supported
Comments suppressed due to low confidence (1)

core-web/libs/edit-content/src/lib/store/features/workflow.feature.ts:310

  • Ensure there is a test case that covers the scenario where workflowStatus is undefined or does not contain the step property.
const { step } = workflowStatus;
@oidacra oidacra enabled auto-merge January 6, 2025 21:04
@oidacra oidacra added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 77740ac Jan 6, 2025
36 checks passed
@oidacra oidacra deleted the 30879-correct-wf-name branch January 6, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Content Edit: UI not displaying actual workflow step
3 participants