Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#31022 Setting host Id in Url Map events #31092

Merged
merged 1 commit into from
Jan 9, 2025
Merged

#31022 Setting host Id in Url Map events #31092

merged 1 commit into from
Jan 9, 2025

Conversation

freddyDOTCMS
Copy link
Contributor

@freddyDOTCMS freddyDOTCMS commented Jan 9, 2025 •
edited by github-actions bot
Loading

Proposed Changes

  • Setting conHost in the Url Map events

https://github.com/dotCMS/core/pull/31092/files#diff-ace471e1bb6fabbd5bf415f1a2deb9f5e6c376bfb90522c81a5c680ae2ec2989R98

  • Fixing util test methods to compare 2 Map, if the collected Map does not contains a expected key we must failed the test

https://github.com/dotCMS/core/pull/31092/files#diff-0ca21ccadd3dee8d7347179578d8a7e675396246effe31a9f74a302d4142b0d1R329-R330

This PR fixes: #31022

@github-actions github-actions bot mentioned this pull request Jan 9, 2025
Open
@freddyDOTCMS freddyDOTCMS marked this pull request as ready for review January 9, 2025 16:45
@freddyDOTCMS freddyDOTCMS added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 75bf2c2 Jan 9, 2025
37 checks passed
@freddyDOTCMS freddyDOTCMS deleted the issue-31022-setting-hostId-in-url-map-events branch January 9, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdotcms jdotcms jdotcms approved these changes

@jcastro-dotcms jcastro-dotcms jcastro-dotcms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Host save as null in PAGE_REQUEST events
3 participants
@freddyDOTCMS @jcastro-dotcms @jdotcms