Ensure WebAuthenticator URL is fully encoded to avoid issues with cer…

…tain OAuth servers (#146) Fixes #144
dotMorten · Nov 7, 2023 · c834d3d · c834d3d
1 parent 3c02913
commit c834d3d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/Directory.Build.targets b/src/Directory.Build.targets
@@ -17,8 +17,8 @@
     <Authors>Morten Nielsen - https://xaml.dev</Authors>
     <Company>Morten Nielsen - https://xaml.dev</Company>
     <PackageIcon>logo.png</PackageIcon>
-    <Version>2.3.2</Version>
-    <PackageValidationBaselineVersion>2.3.1</PackageValidationBaselineVersion>
+    <Version>2.3.3</Version>
+    <PackageValidationBaselineVersion>2.3.2</PackageValidationBaselineVersion>
   </PropertyGroup>
 
   <ItemGroup Condition="'$(PackageId)'!=''">

diff --git a/src/WinUIEx/WebAuthenticator.cs b/src/WinUIEx/WebAuthenticator.cs
@@ -260,7 +260,7 @@ private async Task<WebAuthenticatorResult> Authenticate(Uri authorizeUri, Uri ca
 
             var process = new System.Diagnostics.Process();
             process.StartInfo.FileName = "rundll32.exe";
-            process.StartInfo.Arguments = $"url.dll,FileProtocolHandler \"{authorizeUri.ToString().Replace("\"","%22")}\"";
+            process.StartInfo.Arguments = $"url.dll,FileProtocolHandler \"{authorizeUri.OriginalString}\"";
             process.StartInfo.UseShellExecute = true;
             process.Start();
             tasks.Add(taskId, tcs);

diff --git a/src/WinUIEx/WinUIEx.csproj b/src/WinUIEx/WinUIEx.csproj
@@ -24,7 +24,7 @@
     <PackageId>WinUIEx</PackageId>
     <Product>WinUI Extensions</Product>
     <PackageReleaseNotes>
-      - Fixed WebAuthenticator issue not working with FireFox (#117)
+      - Ensure WebAuthenticator URL is fully encoded to avoid issues with certain OAuth servers (#144)
     </PackageReleaseNotes>
   </PropertyGroup>