Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: match all non-idle cpu modes when calculating total cpu usage #81

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

uhthomas
Copy link
Contributor

@uhthomas uhthomas commented Dec 18, 2023

Fixes: #80

Pull Request

Required Fields

🔎 What kind of change is it?

  • fix

🎯 What has been changed and why do we need it?

  • Total CPU usage is now calculated based on all non-idle CPU modes. This is needed to prevent reporting negative values.

Optional Fields

✔️ Which issue(s) this PR fixes?

💬 Additional information?

@uhthomas uhthomas requested a review from dotdc as a code owner December 18, 2023 13:09
@jkroepke
Copy link
Contributor

I do my review here: #80 (comment)

Unless I do something wrong, the values are more incorrect now.

Copy link
Owner

@dotdc dotdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks way better now!
Could you please remove the unneeded "sum by instance" on the nodes dashboard and bump the version on both dashboards (at the end)?

dashboards/k8s-views-nodes.json Outdated Show resolved Hide resolved
@uhthomas
Copy link
Contributor Author

uhthomas commented Jan 5, 2024

Done @dotdc

@dotdc dotdc merged commit 5ff5277 into dotdc:master Jan 5, 2024
1 check passed
@dotdc
Copy link
Owner

dotdc commented Jan 5, 2024

Thank you for your contribution @uhthomas ! 🎉

@uhthomas
Copy link
Contributor Author

uhthomas commented Jan 5, 2024

Thank you for your contribution @uhthomas ! 🎉

Thank you for your patience and help :) I'm glad we got there in the end.

@dotdc
Copy link
Owner

dotdc commented Apr 25, 2024

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dotdc dotdc added the released label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] CPU dashboard can report negative values
3 participants