-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: match all non-idle cpu modes when calculating total cpu usage #81
Conversation
I do my review here: #80 (comment) Unless I do something wrong, the values are more incorrect now. |
f46877d
to
e04a0b9
Compare
737af30
to
d8420f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks way better now!
Could you please remove the unneeded "sum by instance" on the nodes dashboard and bump the version on both dashboards (at the end)?
Done @dotdc |
Thank you for your contribution @uhthomas ! 🎉 |
Thank you for your patience and help :) I'm glad we got there in the end. |
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Fixes: #80
Pull Request
Required Fields
🔎 What kind of change is it?
🎯 What has been changed and why do we need it?
Optional Fields
✔️ Which issue(s) this PR fixes?
💬 Additional information?