Skip to content

Commit

Permalink
Merge pull request #4 from AdamKobus/ST-134-2
Browse files Browse the repository at this point in the history
ST-134 Fabric is now properly configured for custom build types
  • Loading branch information
pawelkobojek authored Jun 24, 2016
2 parents bbf1c90 + 5254bcd commit 4f4d748
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ buildscript {
}
}
dependencies {
classpath 'com.infullmobile:toolkit:0.3.10'
classpath 'com.infullmobile:toolkit:0.3.12'
}
}
```
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class ConfigureCoverageCommand extends IConfigCommand {

@Override
void performCommand(IProjectConfigurator configurator) {
configuredProject.android.buildTypes.each() { buildType ->
configuredProject.android.buildTypes.all() { buildType ->
buildType.testCoverageEnabled = true
}
if(!PluginsUtils.hasJacocoPlugin(configuredProject)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ class ConfigureFabricCommand extends IConfigCommand {
if (!PluginsUtils.hasFabricPlugin(configuredProject)) {
return;
}
configuredProject.android.buildTypes.each { buildType ->
def team = getChosenFabricTeam();
configuredProject.android.buildTypes.all { buildType ->
def String team = getChosenFabricTeam();
if (team) {
buildType.ext.betaDistributionGroupAliases = team
}
Expand All @@ -34,14 +34,10 @@ class ConfigureFabricCommand extends IConfigCommand {
}

def getChosenFabricTeam() {
def team = configuredProject.hasProperty('fabricTeam') ? configuredProject.fabricTeam : config.defaultFabricTeam
println ">> Fabric team is set to $team on project ${configuredProject.name}"
return team
return configuredProject.hasProperty('fabricTeam') ? configuredProject.fabricTeam : config.defaultFabricTeam
}

def getChangelogPath() {
def path = configuredProject.hasProperty('fabricChangelogPath') ? configuredProject.fabricChangelogPath : null
println ">> Changelog path is set to $path in project ${configuredProject.name}"
return path
return configuredProject.hasProperty('fabricChangelogPath') ? configuredProject.fabricChangelogPath : null
}
}

0 comments on commit 4f4d748

Please sign in to comment.