Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rawScanRecord #1134

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Conversation

KamilNatonek
Copy link
Contributor

@KamilNatonek KamilNatonek commented Nov 13, 2023

No description provided.

@dominik-czupryna-withintent
Copy link
Contributor

resolves #949
resolves #970

@dominik-czupryna-withintent dominik-czupryna-withintent merged commit 26b6188 into master Nov 14, 2023
9 checks passed
@simon-spobu
Copy link

Hi,
just a quick note for this line:

let advertisementDataJSON = try? JSONSerialization.data(withJSONObject: advertisementDataDict, options: [])

rawScanRecord indicates it is the raw BLE advertisment data, but currently its just a copy of hand picked key/value pairs of the data.
I guess this should better not copy advertisementDataDict but rather advertisementData? But maybe still make the contents of advertisementDataDict somehow available like the way it was before this commit?

regards simon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants