Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request variables section typo #34670

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Fix request variables section typo #34670

merged 1 commit into from
Feb 7, 2025

Conversation

gy-ch
Copy link
Contributor

@gy-ch gy-ch commented Feb 7, 2025

Under Request variables heading, the example given is # @name login but under Example request variable usage heading is #@name login which doesn't have space between # and @name and it doesn't work in Visual Studio. It may confuse readers who jump directly to the Example request variable usage heading.


Internal previews

📄 File 🔗 Preview link
aspnetcore/test/http-files.md Use .http files in Visual Studio 2022

Under Request variables heading, the example given is `# @name login` but under Example request variable usage heading is `#@name login` which doesn't have space between `#` and `@name` and it doesn't work in Visual Studio. It may confuse readers who jump directly to the Example request variable usage heading.
@guardrex guardrex requested a review from tdykstra February 7, 2025 14:44
@wadepickett wadepickett self-requested a review February 7, 2025 16:25
Copy link
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, appreciated!

@wadepickett wadepickett merged commit 62f6fb0 into dotnet:main Feb 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants