fix: target current LTS framework for Microsoft.AspNetCore.Connections.Abstractions
#59219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeagleGross
requested review from
halter73,
BrennanConroy,
JamesNK and
mgravell
as code owners
dotnet-issue-labeler
bot
added
the
area-networking
|
It makes sense to me, to avoid foot-shotguns, as illustrated by Orleans. If our own team can fall into it: externals are doomed! |
mgravell
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Orleans users filed issue, where
Microsoft.AspNetCore.Connections.Abstractionswas used as anetstandard2.1NuGet, because of missing .net8 (current LTS) framework target.This resulted in missing specific properties on interfaces (see ITlsHandshakeFeature.NegotiatedCipherSuite), which are not included with
netstandardpackage because of preprocessor directives.@ReubenBond has already changed the references for Orleans; now it is targeting .net8, so the issue is resolved:
dotnet/orleans#9238 (comment)
However, I think including LTS as a target framework for
Microsoft.AspNetCore.Connections.Abstractionslibrary would still be safe and useful from the aspnetcore side.Fixes #59095