Allow overriding of NavLink's ShouldMatch method
#59903
Draft
+110
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-blazor
ilonatommy
changed the title
NavLink.All on "\" location does not match urls with queries nor fragmentsNavLink.All should match urls with queries and fragments
|
The option of exposing |
ilonatommy
changed the title
NavLink.All should match urls with queries and fragmentsNavLink's ShouldMatch method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShouldMatchmethod inNavLinkcan be overridden by the developersDescription
Appending a query to home url that is marked as
NavLink.Allin the navigation layout, resulted in un-selecting it in the navigation tab. This was reported as confusing for the users.In #32168 a property to skip query in the uri comparison was proposed, but it does not solve such cases as appended fragments etc. From this reason, this PR implements the other approach from #32168 (comment).
We expose
ShouldMatchand users can create their own version ofNavLink, e.g.NavLinkIgnoreQueryAndFragmentString(see tests). UsingNavLinkIgnoreQueryAndFragmentStringsolves the reported issue.Fixes #31312.