Add HostedCommandHandler helper class #1356
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in #1344 we have detected flaws in the implementation of the
UseCommandHandler
extension methods.This PR adds a new helper class
HostedCommandHandler
which works similarly toCommandHandler
by creating instances ofICommandHandler
that forward the call toInvokeAsync(InvocationContext)
to a handler instance constructed by the .NET Generic Host DI-system.UseCommandHandler
is removed by this PR.Test have also been updated to use the
HostedCommandHandler
instead ofUseCommandHandler
.The test have also been adjusted to better reflect design principles using the .NET Generic Host. In particular this involves having options-classes that hold the values bound from command-line. The handlers get an injected
IOptions<T>
instance from which they read bound command-line argument values./cc @leonardochaia, @Gronex
A minimalistic example of using DI-bound handlers would look like this:
closes #1344