Update release/stable #5246
Merged
Update release/stable #5246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add DAC cert check Calls the CLRMD signing and cert checking helper function before loading the DAC module. The check honors the Debugger.Settings.EngineInitialization.SecureLoadDotNetExtensions setting when running under windbg. Defaults to true under dotnet-dump on Windows, false on Linux/MacOS for dotnet-dump and lldb. TestHost (used by the Microsoft.Diagnostics.DebugServices.UnitTests, etc.) disables the signature check because all the test asset dumps used are preview 6.0 and not signed (that needs to be fixed but it is beyond the scope of this PR). ---- #### AI description (iteration 1) #### PR Classification New feature #### PR Summary This pull request introduces a new feature to check DAC certificate validity. - Added `GetSettings` method in `dbgengservices.cpp` to retrieve debugger settings. - Implemented `DacSignatureVerificationEnabled` property in `HostServices.cs` and `DebuggerServices.cs` to enforce DAC certificate validation. - Created new interface `ISettingsService` in `ISettingsService.cs` to define settings service. - Updated `RuntimeWrapper.cs` to verify DAC signing and certificate before loading. - Modified `Versions.props` to update `MicrosoftDiagnosticsRuntimeVersion` to `4.0.0-beta.24521.1`.
…able #### AI description (iteration 1) #### PR Classification Merge latest release/stable into internal/release/stable #### PR Summary This pull request merges the latest stable release into the internal stable branch, incorporating various updates and improvements. - `src/SOS/Strike/disasmLOONGARCH64.cpp`: Implemented the `Unassembly` function for LOONGARCH64, replacing the NYI (Not Yet Implemented) assertion. - `eng/Version.Details.xml`: Updated dependencies to newer versions. - `eng/common/native/install-dependencies.sh`: Added a new script to install necessary dependencies for CI. - `src/Microsoft.Diagnostics.DebugServices.Implementation/Thread.cs` and `ThreadService.cs`: Refactored methods to improve register value retrieval and thread context handling. - `eng/common/core-templates/job/job.yml`: Refactored MicroBuild plugin installation and cleanup steps into separate templates.
Update to latest Microsoft-clrmd version
…fication enabled #### AI description (iteration 1) #### PR Classification Bug fix #### PR Summary This pull request ensures that the runtime implementation fails the fallback path if DAC signature verification is enabled. - `src/SOS/Strike/platform/runtimeimpl.cpp`: Added checks to fail the fallback path if DAC signature verification is enabled or if `GetDebuggerServices` returns `nullptr`. - `src/SOS/SOS.UnitTests/SOSRunner.cs`: Modified the initialization of `SecureLoadDotNetExtensions` based on new conditions.
Merge release/stable into internal/release/stable ---- #### AI description (iteration 1) #### PR Classification Code enhancement and feature addition. #### PR Summary This pull request merges the `release/stable` branch into `internal/release/stable`, introducing new features and code enhancements. - `src/SOS/Strike/strike.cpp`: Added functions `SaveModulesFromDomain`, `SaveModule`, and `SaveAllModules` to enhance module saving capabilities. - `src/Microsoft.Diagnostics.DebugServices.Implementation/Host.cs`: Introduced a new `Host` class to manage services and targets. - `src/Microsoft.Diagnostics.TestHelpers/TestHost/TestDump.cs`: Refactored to use the new `Host` class and added `DumpTargetFactory`. - `src/Tools/dotnet-dump/Analyzer.cs`: Refactored to utilize the new `Host` class and `DumpTargetFactory` for better service management. - `eng/Version.Details.xml`: Updated dependencies to newer versions.
- `src/SOS/Strike/clrma/managedanalysis.cpp`: Fixed issues with `GetClrDataProcess` and `QueryInterface` calls, ensuring proper handling and reference management of `m_clrData` and `m_sosDac`. Added error handling to prevent fallback to old SOS unstructured provider.
#### AI description (iteration 1) #### PR Classification Code cleanup and configuration update. #### PR Summary This pull request updates the release management process to use WIF (Workload Identity Federation) connection. - Modified `prepare-release.yml` to remove SAS token generation steps and update Azure subscription. - Updated `AcquireBuild.ps1` to remove SAS suffixes parameter and use Azure credentials for blob access.
Add auth call to release
mikem8361
approved these changes
Feb 12, 2025
tommcdon
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.