Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paramrefs (System.Diagnostics, System.DirectoryServices) #10793

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

gewarren
Copy link
Contributor

Contributes to #10183.

(Hide whitespace changes.)

@gewarren gewarren requested a review from a team as a code owner December 28, 2024 02:03
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Dec 28, 2024
Copy link

Learn Build status updates of commit 71b741f:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Device.Location/GeoCoordinate.xml ✅Succeeded View
xml/System.Diagnostics/ActivityContext.xml ✅Succeeded View
xml/System.Diagnostics/ActivityLink.xml ✅Succeeded View
xml/System.Diagnostics/EventLog.xml ✅Succeeded View
xml/System.Diagnostics/PerformanceCounterCategory.xml ✅Succeeded View
xml/System.Diagnostics/ProcessStartInfo.xml ✅Succeeded View
xml/System.Diagnostics/TagList.xml ✅Succeeded View
xml/System.Diagnostics/TraceListenerCollection.xml ✅Succeeded View
xml/System.Diagnostics/XmlWriterTraceListener.xml ✅Succeeded View
xml/System.DirectoryServices.AccountManagement/PrincipalContext.xml ✅Succeeded View
xml/System.DirectoryServices.ActiveDirectory/ActiveDirectorySchedule.xml ✅Succeeded View
xml/System.DirectoryServices.ActiveDirectory/ActiveDirectorySchema.xml ✅Succeeded View
xml/System.DirectoryServices.ActiveDirectory/ActiveDirectorySchemaPropertyCollection.xml ✅Succeeded View
xml/System.DirectoryServices.ActiveDirectory/ActiveDirectorySiteLink.xml ✅Succeeded View
xml/System.DirectoryServices.ActiveDirectory/Domain.xml ✅Succeeded View
xml/System.DirectoryServices.ActiveDirectory/Forest.xml ✅Succeeded View
xml/System.DirectoryServices.ActiveDirectory/ForestTrustDomainInformation.xml ✅Succeeded View
xml/System.DirectoryServices.ActiveDirectory/ReadOnlyStringCollection.xml ✅Succeeded View
xml/System.DirectoryServices.Protocols/DirectoryAttribute.xml ✅Succeeded View
xml/System.DirectoryServices.Protocols/DirectoryRequest.xml ✅Succeeded View
xml/System.DirectoryServices.Protocols/DsmlRequestDocument.xml ✅Succeeded View
xml/System.DirectoryServices.Protocols/LdapConnection.xml ✅Succeeded View
xml/System.DirectoryServices.Protocols/LdapDirectoryIdentifier.xml ✅Succeeded View
xml/System.DirectoryServices.Protocols/SearchResultEntryCollection.xml ✅Succeeded View
xml/System.DirectoryServices.Protocols/SearchResultReferenceCollection.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit c4ec88b into dotnet:main Jan 7, 2025
4 checks passed
@gewarren gewarren deleted the paramrefs-122724 branch January 7, 2025 18:15
@gewarren
Copy link
Contributor Author

gewarren commented Jan 7, 2025

Thanks @BillWagner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants